Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Change default payload of test run #37742

Closed
ayushpahwa opened this issue Nov 26, 2024 · 0 comments · Fixed by #38443
Closed

[Task] Change default payload of test run #37742

ayushpahwa opened this issue Nov 26, 2024 · 0 comments · Fixed by #38443
Assignees
Labels
Task A simple Todo Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product

Comments

@ayushpahwa
Copy link
Contributor

No description provided.

@ayushpahwa ayushpahwa added Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product labels Nov 26, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Nov 26, 2024
@ayushpahwa ayushpahwa self-assigned this Nov 26, 2024
ayushpahwa added a commit that referenced this issue Jan 2, 2025
## Description
The `getTestPayloadFromCollectionData` extracts the `testPayload` from
passed `collectionData` and returns an empty string if no information is
present. This PR updates the function definition to allow different
default value based on the function call.


Fixes #37742 

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12572189037>
> Commit: 26ea6e2
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12572189037&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 01 Jan 2025 16:34:44 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
  - Enhanced function handling for undefined collection data
  - Improved key iteration in action execution utilities

- **Documentation**
  - Added JSDoc comment to clarify function behavior

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task A simple Todo Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants