Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset host in Route resource #299

Open
6 tasks done
leochr opened this issue Dec 16, 2021 · 3 comments
Open
6 tasks done

Reset host in Route resource #299

leochr opened this issue Dec 16, 2021 · 3 comments
Assignees
@idlewis
Labels
zenhub-dev

Comments

@leochr
Copy link
Member

leochr commented Dec 16, 2021 •
edited by idlewis
Loading

Configure host for Route:

spec:
  expose: true
  route:
    host: mycompany-host

Created Route resource will get the host values

Then remove the route field

spec:
  expose: true

The Route resource still has the host value.

  • RCO
    • Fixed
    • Added tests
  • OLO
    • Fixed
    • Added tests
  • WLO
    • Fixed
    • Added tests
@leochr leochr added help wanted Extra attention is needed high labels Dec 16, 2021
@idlewis idlewis self-assigned this Jan 10, 2022
@leochr leochr mentioned this issue Jan 23, 2023
Closed
6 tasks
@idlewis idlewis mentioned this issue Mar 10, 2023
Merged
@leochr leochr removed the help wanted Extra attention is needed label Mar 29, 2023
@leochr leochr added zenhub-dev and removed high labels Apr 11, 2023
@leochr
Copy link
Member Author

leochr commented Apr 13, 2023

Changing this issue for route host onlly. Something to address in the future.
Route path not being removed issue is tracked/fixed via OpenLiberty/open-liberty-operator#363

@leochr leochr changed the title Remove host and path from Route resource Reset host in Route resource Apr 13, 2023
@idlewis idlewis mentioned this issue May 18, 2023
Merged
This was referenced Mar 14, 2024
Merged
Merged
@idlewis
Copy link
Collaborator

idlewis commented Mar 15, 2024

This isn't quite done as some code should be common.
#618 does this for RCO, but OLO and WLO are also needed

@idlewis
Copy link
Collaborator

idlewis commented Apr 10, 2024

WASdev/websphere-liberty-operator#631
OpenLiberty/open-liberty-operator#567
Make the move to common code for OLO and WLO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idlewis idlewis

Labels
zenhub-dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@idlewis @leochr