Skip to content

Commit 06be29f

Browse files
authored
ClientEffectiveStrategyTest and ServerEffectiveStrategyTest cleanups (#1667)
* `ClientEffectiveStrategyTest` cleanups Motivation: The parameterization pattern used for `ClientEffectiveStrategyTest` makes it difficult to understand the configuration under test because it is built imperatively rather than as a set of declarative options. Some refactoring Modifications: Restructured test parameterization. One specific case is improved; for the cases where no offloading to provided executor is to be performed the test now explicitly ensures that the test fails if the executor is used. Result: Easier to understand test with easier to understand test cases.
1 parent 3dd8f13 commit 06be29f

File tree

3 files changed

+207
-260
lines changed

3 files changed

+207
-260
lines changed

servicetalk-http-api/src/main/java/io/servicetalk/http/api/StrategyInfluencerChainBuilder.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ private StrategyInfluencerChainBuilder(Deque<HttpExecutionStrategyInfluencer> in
5050
* Adds the passed {@link HttpExecutionStrategyInfluencer} to the head of this chain.
5151
*
5252
* @param influencer {@link HttpExecutionStrategyInfluencer} to add.
53-
* @throws IndexOutOfBoundsException If the passed index is invalid.
5453
*/
5554
public void prepend(HttpExecutionStrategyInfluencer influencer) {
5655
influencers.addFirst(requireNonNull(influencer));
@@ -62,7 +61,6 @@ public void prepend(HttpExecutionStrategyInfluencer influencer) {
6261
*
6362
* @param mayBeInfluencer An object which may be an {@link HttpExecutionStrategyInfluencer}.
6463
* @return {@code true} if the passed {@code mayBeInfluencer} was added to the chain.
65-
* @throws IndexOutOfBoundsException If the passed index is invalid.
6664
*/
6765
public boolean prependIfInfluencer(Object mayBeInfluencer) {
6866
if (mayBeInfluencer instanceof HttpExecutionStrategyInfluencer) {

0 commit comments

Comments
 (0)