Skip to content

Commit e7ee340

Browse files
committed
Merge branch 'tom-styling-fixes' into fix-past-challenges
2 parents ee3e2e6 + 4bb6f2d commit e7ee340

File tree

5 files changed

+19
-11
lines changed

5 files changed

+19
-11
lines changed

components/ChallengeCard/Tooltips/TrackAbbreviationTooltip/TrackAbbreviationTooltip.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ const DESCRIPTION = {
1414
APPLICATION_FRONT_END_DESIGN: 'Design UI and front end experiences for apps',
1515
ARCHITECTURE: 'Architect modules, components, or full applications',
1616
ASSEMBLY_COMPETITION: 'Develop code for a variety of use cases. Rigorous review and final fix process is included.',
17-
BANNERS_OR_ICONS: 'Insert copy text here',
17+
BANNERS_OR_ICONS: 'Design UI assets for use in web, mobile, print, and other digital formats',
1818
CODE: 'Develop code for apps, services, etc. Final fixes are not included',
19-
CONCEPTUALIZATION: 'Insert copy text here',
20-
DESIGN_FIRST_2_FINISH: 'Be the first to deliver the solution',
21-
FIRST_2_FINISH: 'Be the first to deliver the solution',
19+
CONCEPTUALIZATION: 'Discover and define user stories and requirements',
20+
DESIGN_FIRST_2_FINISH: 'Be the first to deliver the design solution',
21+
FIRST_2_FINISH: 'Be the first to deliver the development solution',
2222
MARATHON_MATCH: 'Write algorythms to solve complex problems, often for real world issues',
2323
PRINT_OR_PRESENTATION: 'Design print and presentation assets',
2424
SRM: 'Single Round Match - quickly write code to solve algorythm problems head to head against other competitors',

components/ChallengeFilters/ChallengeFilterWithSearch.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@ class Filter extends BaseFilter {
3737
return (item) => {
3838
if (!parent(item)) return false;
3939
if (this.query) {
40-
const platforms = item.platforms.join(' ');
41-
const techs = item.technologies.join(' ');
42-
const str = `${item.challengeName} ${platforms} ${techs}`.toLowerCase();
40+
const str = `${item.name} ${item.platforms} ${item.technologies}`.toLowerCase();
4341
if (str.indexOf(this.query.toLowerCase()) < 0) return false;
4442
}
4543
return true;

components/ChallengeFilters/ChallengeFiltersExample.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,9 +307,11 @@ class ChallengeFiltersExample extends React.Component {
307307

308308
onFilterByTopFilter(filter, isSidebarFilter) {
309309
const mergedFilter = Object.assign({}, this.state.filter, filter);
310-
const updatedFilter = new SideBarFilter(mergedFilter);
310+
let updatedFilter = new SideBarFilter(mergedFilter);
311311
if (!isSidebarFilter) {
312312
updatedFilter.mode = SideBarFilterModes.CUSTOM;
313+
} else {
314+
updatedFilter = this.state.filter.copySidebarFilterProps(updatedFilter);
313315
}
314316
this.setState({ filter: updatedFilter }, this.saveFiltersToHash.bind(this, updatedFilter));
315317
}

components/SideBarFilters/SideBarFilter.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,13 @@ class SideBarFilter extends ChallengeFilter {
104104
return this;
105105
}
106106

107+
copySidebarFilterProps(filter) {
108+
if (!filter._isSideBarFilter) return this;
109+
this.name = _.clone(filter.name);
110+
this.uuid = _.clone(filter.uuid);
111+
return this;
112+
}
113+
107114
stringify() {
108115
return btoa(JSON.stringify([
109116
super.stringify(),

components/SideBarFilters/SideBarFilters.jsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -425,13 +425,14 @@ class SideBarFilters extends React.Component {
425425
*/
426426
selectFilterWithName(filterName) {
427427
// find a filter with matching name
428-
const currentFilter = _.find(this.state.filters, filter => filter.name === filterName);
429-
if (currentFilter.mode === 'Open for review') {
428+
const selectedFilter = _.find(this.state.filters, filter => filter.name === filterName);
429+
if (selectedFilter.mode === 'Open for review') {
430430
// Jump to Development Review Opportunities page
431431
window.location.href = `${this.props.config.MAIN_URL}/review/development-review-opportunities/`;
432432
return;
433433
}
434-
this.setState({ currentFilter }, () => this.props.onFilter(currentFilter));
434+
const mergedFilter = this.props.filter.copySidebarFilterProps(selectedFilter);
435+
this.setState({ currentFilter: mergedFilter }, () => this.props.onFilter(mergedFilter));
435436
}
436437

437438
/**

0 commit comments

Comments
 (0)