Skip to content

Commit 70fb1f5

Browse files
authored
Merge pull request #235 from royshouvik/fix-tc-1188
Fix issue #1188
2 parents 09ab1ba + e322154 commit 70fb1f5

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

components/ChallengeFilters/ChallengeFiltersExample.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,9 +307,11 @@ class ChallengeFiltersExample extends React.Component {
307307

308308
onFilterByTopFilter(filter, isSidebarFilter) {
309309
const mergedFilter = Object.assign({}, this.state.filter, filter);
310-
const updatedFilter = new SideBarFilter(mergedFilter);
310+
let updatedFilter = new SideBarFilter(mergedFilter);
311311
if (!isSidebarFilter) {
312312
updatedFilter.mode = SideBarFilterModes.CUSTOM;
313+
} else {
314+
updatedFilter = this.state.filter.copySidebarFilterProps(updatedFilter);
313315
}
314316
this.setState({ filter: updatedFilter }, this.saveFiltersToHash.bind(this, updatedFilter));
315317
}

components/SideBarFilters/SideBarFilter.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,13 @@ class SideBarFilter extends ChallengeFilter {
104104
return this;
105105
}
106106

107+
copySidebarFilterProps(filter) {
108+
if (!filter._isSideBarFilter) return this;
109+
this.name = _.clone(filter.name);
110+
this.uuid = _.clone(filter.uuid);
111+
return this;
112+
}
113+
107114
stringify() {
108115
return btoa(JSON.stringify([
109116
super.stringify(),

components/SideBarFilters/SideBarFilters.jsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -425,13 +425,14 @@ class SideBarFilters extends React.Component {
425425
*/
426426
selectFilterWithName(filterName) {
427427
// find a filter with matching name
428-
const currentFilter = _.find(this.state.filters, filter => filter.name === filterName);
429-
if (currentFilter.mode === 'Open for review') {
428+
const selectedFilter = _.find(this.state.filters, filter => filter.name === filterName);
429+
if (selectedFilter.mode === 'Open for review') {
430430
// Jump to Development Review Opportunities page
431431
window.location.href = `${this.props.config.MAIN_URL}/review/development-review-opportunities/`;
432432
return;
433433
}
434-
this.setState({ currentFilter }, () => this.props.onFilter(currentFilter));
434+
const mergedFilter = this.props.filter.copySidebarFilterProps(selectedFilter);
435+
this.setState({ currentFilter: mergedFilter }, () => this.props.onFilter(mergedFilter));
435436
}
436437

437438
/**

0 commit comments

Comments
 (0)