File tree 3 files changed +14
-4
lines changed
3 files changed +14
-4
lines changed Original file line number Diff line number Diff line change @@ -307,9 +307,11 @@ class ChallengeFiltersExample extends React.Component {
307
307
308
308
onFilterByTopFilter ( filter , isSidebarFilter ) {
309
309
const mergedFilter = Object . assign ( { } , this . state . filter , filter ) ;
310
- const updatedFilter = new SideBarFilter ( mergedFilter ) ;
310
+ let updatedFilter = new SideBarFilter ( mergedFilter ) ;
311
311
if ( ! isSidebarFilter ) {
312
312
updatedFilter . mode = SideBarFilterModes . CUSTOM ;
313
+ } else {
314
+ updatedFilter = this . state . filter . copySidebarFilterProps ( updatedFilter ) ;
313
315
}
314
316
this . setState ( { filter : updatedFilter } , this . saveFiltersToHash . bind ( this , updatedFilter ) ) ;
315
317
}
Original file line number Diff line number Diff line change @@ -104,6 +104,13 @@ class SideBarFilter extends ChallengeFilter {
104
104
return this ;
105
105
}
106
106
107
+ copySidebarFilterProps ( filter ) {
108
+ if ( ! filter . _isSideBarFilter ) return this ;
109
+ this . name = _ . clone ( filter . name ) ;
110
+ this . uuid = _ . clone ( filter . uuid ) ;
111
+ return this ;
112
+ }
113
+
107
114
stringify ( ) {
108
115
return btoa ( JSON . stringify ( [
109
116
super . stringify ( ) ,
Original file line number Diff line number Diff line change @@ -425,13 +425,14 @@ class SideBarFilters extends React.Component {
425
425
*/
426
426
selectFilterWithName ( filterName ) {
427
427
// find a filter with matching name
428
- const currentFilter = _ . find ( this . state . filters , filter => filter . name === filterName ) ;
429
- if ( currentFilter . mode === 'Open for review' ) {
428
+ const selectedFilter = _ . find ( this . state . filters , filter => filter . name === filterName ) ;
429
+ if ( selectedFilter . mode === 'Open for review' ) {
430
430
// Jump to Development Review Opportunities page
431
431
window . location . href = `${ this . props . config . MAIN_URL } /review/development-review-opportunities/` ;
432
432
return ;
433
433
}
434
- this . setState ( { currentFilter } , ( ) => this . props . onFilter ( currentFilter ) ) ;
434
+ const mergedFilter = this . props . filter . copySidebarFilterProps ( selectedFilter ) ;
435
+ this . setState ( { currentFilter : mergedFilter } , ( ) => this . props . onFilter ( mergedFilter ) ) ;
435
436
}
436
437
437
438
/**
You can’t perform that action at this time.
0 commit comments