Add default export from graphql-tag/loader modules #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES6 modules expect the default export to be named `default`, rather than using the `module.exports` object. By providing an export named `default` here, we make the module more directly compatible with ES6 modules. The benefit of this is that when you import the default export in an ES6 environment you won't get extra properties on the object for all the named exported operations and fragments in the file. This probably doesn't affect too many people, but it's a little cleanup that might save some trouble / confusion for people who are importing a graphql module and doing more with it than just feeding it into the apollo client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES6 modules expect the default export to be named
default, ratherthan using the
module.exportsobject. By providing an export nameddefaulthere, we make the module more directly compatible with ES6 modules.The benefit of this is that when you import the default export in an ES6 environment
you won't get extra properties on the object for all the named exported operations
and fragments in the file.
This probably doesn't affect too many people, but it's a little cleanup that might save
some trouble / confusion for people who are importing a graphql module and doing more
with it than just feeding it into the apollo client.