Merge rust-bitcoin#836: 10.x: fix CI

4842494 Check that we only accept INPUT_CHARSET in from_str (Andrew Poelstra)
a0e3221 ci: update rustc version for fuzz job (Andrew Poelstra)
4f03d30 clippy: fix reference-related syntax stuff (Andrew Poelstra)
fd102f4 clippy: remove a bunch of unnecessary vec!s (Andrew Poelstra)
e3889d2 clippy: non-reference stuff (Andrew Poelstra)
6afde54 modernize rustfmt::skip syntax and run cargo fmt (Andrew Poelstra)
5cb768b ci: fix broken and redundant doc links (Andrew Poelstra)
972756f ci: set all runners to ubuntu-latest (Andrew Poelstra)
085f13f ci: pin nightly version (Andrew Poelstra)
b57c9a7 ci: pin dependencies using lockfile rather than ad-hoc cargo updates (Andrew Poelstra)

Pull request description:

  Should get us green CI, and pins the nightly compiler version so that it stays green.


ACKs for top commit:
  sanket1729:
    reACK 4842494. 


Tree-SHA512: b3ce8620e45b6dd378391611321d5b50645ac9850ac3bc50bb2ade32df83928d94ac158d35117c2655c7fd34618d13b66cd2edbe636f4202ff5ec3037d3ce95e

Author: apoelstra

.github/workflows/fuzz.yml

@@ -11,7 +11,7 @@ on:
 jobs:
   fuzz:
     if: ${{ !github.event.act }}
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -28,8 +28,8 @@ roundtrip_semantic,
     steps:
       - name: Install test dependencies
         run: sudo apt-get update -y && sudo apt-get install -y binutils-dev libunwind8-dev libcurl4-openssl-dev libelf-dev libdw-dev cmake gcc libiberty-dev
-      - uses: actions/checkout@v2
-      - uses: actions/cache@v2
+      - uses: actions/checkout@v4
+      - uses: actions/cache@v4
         id: cache-fuzz
         with:
           path: |
@@ -39,13 +39,13 @@ roundtrip_semantic,
           key: cache-${{ matrix.target }}-${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.58
+          toolchain: 1.65
           override: true
           profile: minimal
       - name: fuzz
         run: cd fuzz && ./fuzz.sh "${{ matrix.fuzz_target }}"
       - run: echo "${{ matrix.fuzz_target }}" >executed_${{ matrix.fuzz_target }}
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: executed_${{ matrix.fuzz_target }}
           path: executed_${{ matrix.fuzz_target }}
@@ -55,8 +55,8 @@ roundtrip_semantic,
     needs: fuzz
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/download-artifact@v2
+      - uses: actions/checkout@v4
+      - uses: actions/download-artifact@v4
       - name: Display structure of downloaded files
         run: ls -R
       - run: find executed_* -type f -exec cat {} + | sort > executed

.github/workflows/rust.yml

@@ -3,17 +3,29 @@ on: [push, pull_request]
 name: Continuous integration
 
 jobs:
+  Prepare:
+    runs-on: ubuntu-latest
+    outputs:
+      nightly_version: ${{ steps.read_toolchain.outputs.nightly_version }}
+    steps:
+      - name: "Checkout repo"
+        uses: actions/checkout@v4
+      - name: "Read nightly version"
+        id: read_toolchain
+        run: echo "nightly_version=$(cat nightly-version)" >> $GITHUB_OUTPUT
+
   Nightly:
     name: Nightly - Bench + Docs + Fmt
+    needs: Prepare
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Crate
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Checkout Toolchain
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: ${{ needs.Prepare.outputs.nightly_version }}
           override: true
       - name: Running benchmarks
         env:
@@ -33,7 +45,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Crate
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Checkout Toolchain
         uses: actions-rs/toolchain@v1
         with:
@@ -47,18 +59,18 @@ jobs:
 
   Tests:
     name: Tests
+    needs: Prepare
     runs-on: ubuntu-latest
     strategy:
       matrix:
         include:
           - rust: stable
           - rust: beta
-          - rust: nightly
           - rust: 1.41.1
-          - rust: 1.47
+          - rust: ${{ needs.Prepare.outputs.nightly_version }}
     steps:
       - name: Checkout Crate
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Checkout Toolchain
         uses: actions-rs/toolchain@v1
         with:
@@ -72,22 +84,23 @@ jobs:
         run: ./contrib/test.sh
 
   Embedded:
+    needs: Prepare
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Set up QEMU
         run: sudo apt update && sudo apt install -y qemu-system-arm gcc-arm-none-eabi
       - name: Checkout Toolchain
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: ${{ needs.Prepare.outputs.nightly_version }}
           override: true
           components: rust-src
           target: thumbv7m-none-eabi
       - name: Run
         env:
           RUSTFLAGS: "-C link-arg=-Tlink.x"
           CARGO_TARGET_THUMBV7M_NONE_EABI_RUNNER: "qemu-system-arm -cpu cortex-m3 -machine mps2-an385 -nographic -semihosting-config enable=on,target=native -kernel"
-        run: cd embedded && cargo run --target thumbv7m-none-eabi --release
+        run: cp Cargo-recent.lock Cargo.lock && cd embedded && cargo run --target thumbv7m-none-eabi --release