Repository navigation
Redact JSON bodies with a UTF-8 BOM - #54
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 89.81% 89.79% -0.03%
==========================================
Files 46 46
Lines 3506 3507 +1
Branches 412 413 +1
==========================================
Hits 3149 3149
Misses 268 268
- Partials 89 90 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
itssimon
marked this pull request as ready for review
October 9, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON bodies beginning with a UTF-8 byte order mark failed parsing and were exported as unmasked text. Skip a single leading BOM when creating
Utf8JsonReaderso JSON field masking applies to these bodies.Validation:
make checkpassed.make testpassed all 175 existing tests on .NET 10.passwordandtoken.The Codecov checks fail because the new BOM branch is not exercised by the existing suite: patch coverage is 50.00%, and project coverage is 89.79% (-0.03 percentage points).
No tests were added. Local .NET 8 and 9 runs were unavailable because those runtimes are not installed; both passed in CI.