fix(memory-storage): don't increment handledRequestCount when updating a handled request (#3827)

Increments the `handledRequestCount` counter only on the initial request `handledAt` / `orderNo` change. Subsequent `handledAt` changes do not increment the counter.

Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>

Author: anxkhn

packages/memory-storage/src/resource-clients/request-queue.ts

@@ -551,7 +551,7 @@ export class RequestQueueClient extends BaseClient implements storage.RequestQue
             existingQueueById.pendingRequestCount += requestWasHandledBeforeUpdate ? 1 : -1;
         }
 
-        if (requestIsHandledAfterUpdate) {
+        if (isRequestHandledStateChanging && requestIsHandledAfterUpdate) {
             existingQueueById.handledRequestCount += 1;
         }
 

packages/memory-storage/test/request-queue/handledRequestCount-should-update.test.ts

@@ -50,4 +50,24 @@ describe('RequestQueue handledRequestCount should update', () => {
         const updatedStatistics = await requestQueue.get();
         expect(updatedStatistics?.handledRequestCount).toEqual(2);
     });
+
+    test('updating an already handled request should not increment the handledRequestCount again', async () => {
+        const { requestId } = await requestQueue.addRequest({
+            url: 'http://example.com/4',
+            uniqueKey: '4',
+            handledAt: new Date().toISOString(),
+        });
+
+        const { handledRequestCount } = (await requestQueue.get())!;
+
+        await requestQueue.updateRequest({
+            url: 'http://example.com/4',
+            uniqueKey: '4',
+            id: requestId,
+            handledAt: new Date().toISOString(),
+        });
+
+        const updatedStatistics = await requestQueue.get();
+        expect(updatedStatistics?.handledRequestCount).toEqual(handledRequestCount);
+    });
 });