Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from poetry & pipx to uv & uvx #628

Open
janbuchar opened this issue Oct 29, 2024 · 8 comments · May be fixed by #852
Open

Migrate from poetry & pipx to uv & uvx #628

janbuchar opened this issue Oct 29, 2024 · 8 comments · May be fixed by #852
Assignees
@vdusek
Labels
solutioning The issue is not being implemented but only analyzed and planned. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Collaborator

  • uvx crawlee create is a bit sexier than pipx run crawlee create
  • is uv as widely available as pipx? Windows support?
  • any other pitfalls?
@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. solutioning The issue is not being implemented but only analyzed and planned. labels Oct 29, 2024
@matt-hayden
Copy link

uv tool install crawlee adds a link in ~/.local/bin to a sandboxed installation.

@vdusek
Copy link
Collaborator

vdusek commented Nov 29, 2024 •
edited
Loading

I am closing #59 as a duplicate since it is closely related to this issue.

TL;DR: Migrate from poetry & pipx to uv & uvx.

Proposed changes

  • Use uv and uvx for:
    • project bootstrapping,
    • project management,
    • package installation in CI,
    • any other applicable use cases (to be determined).
  • Do not forget to update the docs & landing page.

Next steps

  • Do the research to identify any potential drawbacks or limitations before migrating.

@vdusek vdusek changed the title Consider using uvx instead of pipx for project bootstrapping on the landing page Migrate from poetry & pipx to uv & uvx Nov 29, 2024
@vdusek vdusek mentioned this issue Nov 29, 2024
Closed
@vdusek
Copy link
Collaborator

vdusek commented Dec 2, 2024

Currently uv publish is experimental:

warning: `uv publish` is experimental and may change without warning

@vdusek vdusek self-assigned this Dec 2, 2024
@vdusek
Copy link
Collaborator

vdusek commented Dec 6, 2024

From @janbuchar:

If we decide to mention uvx as well, the corresponding command would be uvx --with crawlee[cli] crawlee create my-crawler, which is... unsexy. See astral-sh/uv#6296 - the --with flag may become unnecessary in the future.

@Mantisus
Copy link
Collaborator

Mantisus commented Dec 29, 2024 •
edited
Loading

From @janbuchar:

If we decide to mention uvx as well, the corresponding command would be uvx --with crawlee[cli] crawlee create my-crawler, which is... unsexy. See astral-sh/uv#6296 - the --with flag may become unnecessary in the future.

uvx crawlee create my-crawler works, --with crawlee[cli] is not necessary

Windows supports

@janbuchar
Copy link
Collaborator Author

uvx crawlee create my-crawler works, --with crawlee[cli] is not necessary

Yep, we're considering adding the cli extra in the future so that the generated project doesn't have to depend on cookiecutter, typer and so on. See #703.

Windows supports

Great to hear that 🙂

@Mantisus
Copy link
Collaborator

Mantisus commented Dec 30, 2024 •
edited
Loading

Yep, we're considering adding the cli extra in the future so that the generated project doesn't have to depend on cookiecutter, typer and so on. See #703.

Oh, got it. But I think it's easier to have cli dependencies like script dependencies for support uvx.

@janbuchar
Copy link
Collaborator Author

Yep, we're considering adding the cli extra in the future so that the generated project doesn't have to depend on cookiecutter, typer and so on. See #703.

Oh, got it. But I think it's easier to have cli dependencies like script dependencies for support uvx.

That looks like something worth checking out, thanks!

@Mantisus Mantisus linked a pull request Dec 31, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdusek vdusek

Labels
solutioning The issue is not being implemented but only analyzed and planned. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: migrate to uv Mantisus/crawlee-python
4 participants
@janbuchar @matt-hayden @vdusek @Mantisus