Render BCMath\Number (PHP 8.4+) as string instead of object

[aaa2000]

Q	A
Branch?	main
Tickets	Closes #6934
License	MIT

Render BCMath\Number (PHP 8.4+) as string instead of object

Before

{
    "@context": "/contexts/MathNumber",
    "@id": "/math_numbers/1",
    "@type": "MathNumber",
    "id": 1,
    "value": {
        "@id": "/.well-known/genid/d884d3a7bec8d1a52024",
        "@type": "Number",
        "scale": 2,
        "value": "300.55"
    }
}

After

{
    "@context": "/contexts/MathNumber",
    "@id": "/math_numbers/1",
    "@type": "MathNumber",
    "id": 1,
    "value": "300.55"
}

The symfony/serializer:7.3 added the NumberNormalizer, the symfony/framework-bundle:7.3 registered it.

In CI and the job PHPUnit (PHP 8.4), api-platform install symfony/framework-bundle:7.2

  - Locking symfony/framework-bundle (7.2.x-dev 42ac8bb)
  - Locking symfony/http-client (v7.3.6)
  - Locking symfony/http-client-contracts (v3.6.0)

if I try locally

composer require --dev "symfony/framework-bundle:7.3" -W --dry-run 

....
- symfony/object-mapper is locked to version 7.4.x-dev and an update of this package was not requested.
- symfony/framework-bundle v7.3.0 conflicts with symfony/object-mapper >=7.4.

[soyuka]

interesting, I'm wondering if this couldn't be added to 4.2 though.

[dunglas]

Suggested change

	if (class_exists(\BcMath\Number::class) && is_a($className, \BcMath\Number::class, true)) {
	if (is_a($className, \BcMath\Number::class, true)) {

IIRC, the call to is_a() will return false if the class doesn't exist.

[dunglas]

I suggest to just bump the minimum required versions to avoid supporting this edge case.

[soyuka]

we just bumped everything to 7.4 if I'm not mistaken

[soyuka]

mhh we did not but indeed we should bump this to 7.4

[aaa2000]

I don’t see the bump to 7.4 on the branch 4.2, I was wondering which components should I bump ?

https://github.com/api-platform/core/blob/4.2/src/JsonSchema/composer.json#L31
https://github.com/api-platform/core/blob/4.2/src/Serializer/composer.json#L30
https://github.com/api-platform/core/blob/4.2/src/Symfony/composer.json#L46

And there’s currently no dependency on symfony/framework-bundle for the api-platform/symfony, should I add it ?