Revert "fix(pagination): make default value of pagination_maximum_items_per_page same as Laravel version"
#7533
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge` same…" This reverts commit 65e137f.
Contributor
|
@soyuka As explained in #7530, I agree to the revert because it affects existing users. However, having different default behavior between the Laravel and Symfony versions is confusing, so I think the default settings for both should ultimately be the same. I think the final specification explained in #7530 (comment) is appropriate. |
Maxcastel
added a commit
to Maxcastel/api-platform-core
that referenced
this pull request
Nov 25, 2025
…s_per_page` same…" (api-platform#7533)" This reverts commit f4a1697.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7396
See reasoning at #7530 (comment)
@ttskch what do you think should we adapt the laravel default instead?