Skip to content

Conversation

@gnolong
Copy link
Contributor

@gnolong gnolong commented Jan 7, 2025

ref #8693
fix #8708

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 7, 2025
@gnolong gnolong marked this pull request as ready for review January 7, 2025 03:51
@gnolong gnolong requested review from a team, ldming, wangyelei and zjx20 as code owners January 7, 2025 03:51
@gnolong gnolong linked an issue Jan 7, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 34.45783% with 272 lines in your changes missing coverage. Please review.

Project coverage is 64.66%. Comparing base (b6d38ea) to head (6b423f9).
Report is 2 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/dataprotection/restore/utils.go 0.00% 75 Missing ⚠️
pkg/dataprotection/restore/manager.go 0.00% 64 Missing ⚠️
controllers/dataprotection/utils.go 59.50% 34 Missing and 15 partials ⚠️
controllers/dataprotection/backup_controller.go 67.81% 20 Missing and 8 partials ⚠️
pkg/dataprotection/utils/utils.go 0.00% 23 Missing ⚠️
pkg/dataprotection/backup/request.go 4.54% 20 Missing and 1 partial ⚠️
pkg/dataprotection/restore/builder.go 0.00% 8 Missing and 2 partials ⚠️
pkg/dataprotection/backup/utils.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8757      +/-   ##
===============================================
- Coverage        64.70%   64.66%   -0.05%     
===============================================
  Files              359      359              
  Lines            45984    46301     +317     
===============================================
+ Hits             29754    29939     +185     
- Misses           13571    13690     +119     
- Partials          2659     2672      +13     
Flag Coverage Δ
unittests 64.66% <34.45%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 7, 2025
@wangyelei wangyelei merged commit 17a521d into release-0.9 Jan 7, 2025
39 checks passed
@wangyelei wangyelei deleted the support/incremental-backup-in-0.9 branch January 7, 2025 07:38
@github-actions github-actions bot added this to the Release 0.9.2 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Features] supports incremental backup

6 participants