@@ -502,9 +502,10 @@ var _ = Describe("Instance Controller", func() {
502502
503503 Context ("membership" , func () {
504504 var (
505- memberJoin = false
506- memberLeave = false
507- memberJoinError , memberLeaveError error
505+ memberJoin = false
506+ memberLeave = false
507+ memberJoinError error
508+ memberLeaveError error
508509 )
509510
510511 BeforeEach (func () {
@@ -553,7 +554,12 @@ var _ = Describe("Instance Controller", func() {
553554 }
554555
555556 It ("create - w/o member join" , func () {
556- setup (false )
557+ createInstObj (instName )
558+
559+ mockPodReady (instObj .Namespace , instObj .Name )
560+ podKey := instKey
561+ podObj := & corev1.Pod {}
562+ Expect (k8sClient .Get (ctx , podKey , podObj )).Should (Succeed ())
557563
558564 By ("check instance status" )
559565 Eventually (testapps .CheckObj (& testCtx , instKey , func (g Gomega , inst * workloads.Instance ) {
@@ -566,7 +572,17 @@ var _ = Describe("Instance Controller", func() {
566572 })
567573
568574 It ("create - w/ member join" , func () {
569- setup (true )
575+ createInstObj (instName , func (f * testapps.MockInstanceFactory ) {
576+ f .SetLifecycleActions (& workloads.LifecycleActions {
577+ MemberJoin : & kbappsv1.Action {Exec : & kbappsv1.ExecAction {}},
578+ MemberLeave : & kbappsv1.Action {Exec : & kbappsv1.ExecAction {}},
579+ })
580+ })
581+
582+ mockPodReady (instObj .Namespace , instObj .Name )
583+ podKey := instKey
584+ podObj := & corev1.Pod {}
585+ Expect (k8sClient .Get (ctx , podKey , podObj )).Should (Succeed ())
570586
571587 By ("check instance status" )
572588 Eventually (testapps .CheckObj (& testCtx , instKey , func (g Gomega , inst * workloads.Instance ) {
@@ -580,7 +596,12 @@ var _ = Describe("Instance Controller", func() {
580596 })
581597
582598 It ("delete w/o member leave" , func () {
583- setup (false )
599+ createInstObj (instName )
600+
601+ mockPodReady (instObj .Namespace , instObj .Name )
602+ podKey := instKey
603+ podObj := & corev1.Pod {}
604+ Expect (k8sClient .Get (ctx , podKey , podObj )).Should (Succeed ())
584605
585606 By ("check instance status" )
586607 Eventually (testapps .CheckObj (& testCtx , instKey , func (g Gomega , inst * workloads.Instance ) {
@@ -601,7 +622,7 @@ var _ = Describe("Instance Controller", func() {
601622 Consistently (memberLeave ).Should (BeFalse ())
602623 })
603624
604- It ("delete w/ member leave - joined replicas" , func () {
625+ PIt ("delete w/ member leave - joined replicas" , func () {
605626 setup (true )
606627
607628 By ("check instance status" )
@@ -624,7 +645,7 @@ var _ = Describe("Instance Controller", func() {
624645 Eventually (memberLeave ).Should (BeTrue ())
625646 })
626647
627- It ("delete w/ member leave - unjoined replicas" , func () {
648+ PIt ("delete w/ member leave - unjoined replicas" , func () {
628649 By ("mock member-join action error" )
629650 memberJoinError = fmt .Errorf ("mock member-join action error" )
630651
0 commit comments