chore: set podService default false (#8743)

Y-Rookie · web-flow · commit 54fb8ee0754f · 2025-01-06T15:52:07.000+08:00
diff --git a/apis/apps/v1alpha1/cluster_types.go b/apis/apps/v1alpha1/cluster_types.go
@@ -1269,6 +1269,7 @@ type ClusterComponentService struct {
 	// Indicates whether to generate individual Services for each Pod.
 	// If set to true, a separate Service will be created for each Pod in the Cluster.
 	//
+	// +kubebuilder:default=false
 	// +optional
 	PodService *bool `json:"podService,omitempty"`
 }
diff --git a/config/crd/bases/apps.kubeblocks.io_clusters.yaml b/config/crd/bases/apps.kubeblocks.io_clusters.yaml
@@ -5144,6 +5144,7 @@ spec:
                             maxLength: 25
                             type: string
                           podService:
+                            default: false
                             description: |-
                               Indicates whether to generate individual Services for each Pod.
                               If set to true, a separate Service will be created for each Pod in the Cluster.
@@ -13790,6 +13791,7 @@ spec:
                                 maxLength: 25
                                 type: string
                               podService:
+                                default: false
                                 description: |-
                                   Indicates whether to generate individual Services for each Pod.
                                   If set to true, a separate Service will be created for each Pod in the Cluster.
diff --git a/config/crd/bases/apps.kubeblocks.io_opsrequests.yaml b/config/crd/bases/apps.kubeblocks.io_opsrequests.yaml
@@ -8640,6 +8640,7 @@ spec:
                                 maxLength: 25
                                 type: string
                               podService:
+                                default: false
                                 description: |-
                                   Indicates whether to generate individual Services for each Pod.
                                   If set to true, a separate Service will be created for each Pod in the Cluster.
diff --git a/controllers/apps/transformer_cluster_component.go b/controllers/apps/transformer_cluster_component.go
@@ -479,10 +479,14 @@ func (c *compPhasePrecondition) match(transCtx *clusterTransformContext, dag *gr
 			return false, client.IgnoreNotFound(err)
 		}
 		if comp.Generation != comp.Status.ObservedGeneration || !c.phaseExpectation(comp) {
+			transCtx.Logger.Info("component waiting: predecessor has generation mismatch or not in upWorking state",
+				"component", comp.Name, "predecessor", predecessor)
 			return false, nil
 		}
 		// create or update if exists in DAG
 		if dagGet(compKey) {
+			transCtx.Logger.Info("waiting for predecessor component in DAG",
+				"component", comp.Name, "predecessor", predecessor)
 			return false, nil
 		}
 	}
diff --git a/deploy/helm/crds/apps.kubeblocks.io_clusters.yaml b/deploy/helm/crds/apps.kubeblocks.io_clusters.yaml
@@ -5144,6 +5144,7 @@ spec:
                             maxLength: 25
                             type: string
                           podService:
+                            default: false
                             description: |-
                               Indicates whether to generate individual Services for each Pod.
                               If set to true, a separate Service will be created for each Pod in the Cluster.
@@ -13790,6 +13791,7 @@ spec:
                                 maxLength: 25
                                 type: string
                               podService:
+                                default: false
                                 description: |-
                                   Indicates whether to generate individual Services for each Pod.
                                   If set to true, a separate Service will be created for each Pod in the Cluster.
diff --git a/deploy/helm/crds/apps.kubeblocks.io_opsrequests.yaml b/deploy/helm/crds/apps.kubeblocks.io_opsrequests.yaml
@@ -8640,6 +8640,7 @@ spec:
                                 maxLength: 25
                                 type: string
                               podService:
+                                default: false
                                 description: |-
                                   Indicates whether to generate individual Services for each Pod.
                                   If set to true, a separate Service will be created for each Pod in the Cluster.

Original file line number	Diff line number	Diff line change
`@@ -1269,6 +1269,7 @@ type ClusterComponentService struct {`
`1269`	`1269`	`// Indicates whether to generate individual Services for each Pod.`
`1270`	`1270`	`// If set to true, a separate Service will be created for each Pod in the Cluster.`
`1271`	`1271`	`//`
	`1272`	`+ // +kubebuilder:default=false`
`1272`	`1273`	`// +optional`
`1273`	`1274`	PodService *bool `json:"podService,omitempty"`
`1274`	`1275`	`}`
Original file line number	Diff line number	Diff line change
`@@ -479,10 +479,14 @@ func (c compPhasePrecondition) match(transCtx clusterTransformContext, dag *gr`
`479`	`479`	`return false, client.IgnoreNotFound(err)`
`480`	`480`	`}`
`481`	`481`	`if comp.Generation != comp.Status.ObservedGeneration \|\| !c.phaseExpectation(comp) {`
	`482`	`+ transCtx.Logger.Info("component waiting: predecessor has generation mismatch or not in upWorking state",`
	`483`	`+ "component", comp.Name, "predecessor", predecessor)`
`482`	`484`	`return false, nil`
`483`	`485`	`}`
`484`	`486`	`// create or update if exists in DAG`
`485`	`487`	`if dagGet(compKey) {`
	`488`	`+ transCtx.Logger.Info("waiting for predecessor component in DAG",`
	`489`	`+ "component", comp.Name, "predecessor", predecessor)`
`486`	`490`	`return false, nil`
`487`	`491`	`}`
`488`	`492`	`}`