Skip to content

Commit 8443f73

Browse files
committed
Fix tests where OpenSSL path is invalid
This is the case for Buildbot where the version of OpenSSL (1.1.1f) is too old.
1 parent 7f59ce7 commit 8443f73

File tree

2 files changed

+24
-8
lines changed

2 files changed

+24
-8
lines changed

test/org/apache/tomcat/security/TestSecurity2017Ocsp.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
import org.junit.AfterClass;
2626
import org.junit.Assert;
27+
import org.junit.Assume;
2728
import org.junit.BeforeClass;
2829
import org.junit.Test;
2930
import org.junit.runner.RunWith;
@@ -44,16 +45,22 @@ public class TestSecurity2017Ocsp extends OcspBaseTest {
4445
private static TesterOcspResponder ocspResponder;
4546

4647
@BeforeClass
47-
public static void startOcspResponder() throws IOException {
48+
public static void startOcspResponder() {
4849
ocspResponder = new TesterOcspResponder();
49-
ocspResponder.start();
50+
try {
51+
ocspResponder.start();
52+
} catch (IOException ioe) {
53+
ocspResponder = null;
54+
}
5055
}
5156

5257

5358
@AfterClass
5459
public static void stopOcspResponder() {
55-
ocspResponder.stop();
56-
ocspResponder = null;
60+
if (ocspResponder != null) {
61+
ocspResponder.stop();
62+
ocspResponder = null;
63+
}
5764
}
5865

5966

@@ -62,6 +69,7 @@ public static void stopOcspResponder() {
6269
*/
6370
@Test(expected=SSLHandshakeException.class)
6471
public void testCVE_2017_15698() throws Exception {
72+
Assume.assumeNotNull(ocspResponder);
6573

6674
Tomcat tomcat = getTomcatInstance();
6775

test/org/apache/tomcat/util/net/ocsp/TestOcspEnabled.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
import org.junit.AfterClass;
2727
import org.junit.Assert;
28+
import org.junit.Assume;
2829
import org.junit.BeforeClass;
2930
import org.junit.Test;
3031
import org.junit.runner.RunWith;
@@ -38,16 +39,22 @@ public class TestOcspEnabled extends OcspBaseTest {
3839
private static TesterOcspResponder ocspResponder;
3940

4041
@BeforeClass
41-
public static void startOcspResponder() throws IOException {
42+
public static void startOcspResponder() {
4243
ocspResponder = new TesterOcspResponder();
43-
ocspResponder.start();
44+
try {
45+
ocspResponder.start();
46+
} catch (IOException ioe) {
47+
ocspResponder = null;
48+
}
4449
}
4550

4651

4752
@AfterClass
4853
public static void stopOcspResponder() {
49-
ocspResponder.stop();
50-
ocspResponder = null;
54+
if (ocspResponder != null) {
55+
ocspResponder.stop();
56+
ocspResponder = null;
57+
}
5158
}
5259

5360

@@ -99,6 +106,7 @@ public static Collection<Object[]> parameters() {
99106

100107
@Test
101108
public void test() throws Exception {
109+
Assume.assumeNotNull(ocspResponder);
102110
try {
103111
doTest(clientCertValid, serverCertValid, verifyClientCert, verifyServerCert);
104112
if (handshakeFailureExpected) {

0 commit comments

Comments
 (0)