Instant is immutable

rmaucher · rmaucher · commit 5ee9e4e14d21 · 2026-01-19T22:38:49.000+01:00
As a result, the end of the request was always the beginning.
BZ69932, regression from 11.0.12
diff --git a/java/org/apache/catalina/valves/AbstractAccessLogValve.java b/java/org/apache/catalina/valves/AbstractAccessLogValve.java
@@ -1061,7 +1061,7 @@ public void addElement(CharArrayWriter buf, Request request, Response response,
             Instant requestStartInstant = Instant.from(request.getCoyoteRequest().getStartInstant());
             long frac;
             if (!usesBegin) {
-                requestStartInstant.plusNanos(time);
+                requestStartInstant = requestStartInstant.plusNanos(time);
             }
             switch (type) {
                 case CLF:

Original file line number	Diff line number	Diff line change
`@@ -1061,7 +1061,7 @@ public void addElement(CharArrayWriter buf, Request request, Response response,`
`1061`	`1061`	`Instant requestStartInstant = Instant.from(request.getCoyoteRequest().getStartInstant());`
`1062`	`1062`	`long frac;`
`1063`	`1063`	`if (!usesBegin) {`
`1064`		`- requestStartInstant.plusNanos(time);`
	`1064`	`+ requestStartInstant = requestStartInstant.plusNanos(time);`
`1065`	`1065`	`}`
`1066`	`1066`	`switch (type) {`
`1067`	`1067`	`case CLF:`