Skip to content

Commit 35c7209

Browse files
committed
Add change log entry for BZ 69982. Minor clean-up.
1 parent 557b1b5 commit 35c7209

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

java/org/apache/tomcat/util/net/NioEndpoint.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1379,26 +1379,29 @@ private boolean socketOrNetworkBufferHasDataLeft() {
13791379
return !socketBufferHandler.isWriteBufferEmpty() || getSocket().getOutboundRemaining() > 0;
13801380
}
13811381

1382+
13821383
/*
13831384
* https://bz.apache.org/bugzilla/show_bug.cgi?id=69982
13841385
*
1385-
* Similar to socketOrNetworkBufferHasDataLeft(), check the additional buffer for TLS
1386+
* Similar to socketOrNetworkBufferHasDataLeft(), check the additional buffer for TLS.
13861387
*/
13871388
@Override
13881389
public boolean hasDataToWrite() {
13891390
return super.hasDataToWrite() || getSocket().getOutboundRemaining() > 0;
13901391
}
13911392

1393+
13921394
/*
13931395
* https://bz.apache.org/bugzilla/show_bug.cgi?id=69982
13941396
*
1395-
* Similar to socketOrNetworkBufferHasDataLeft(), check the additional buffer for TLS
1397+
* Similar to socketOrNetworkBufferHasDataLeft(), check the additional buffer for TLS.
13961398
*/
13971399
@Override
13981400
public boolean canWrite() {
13991401
return super.canWrite() && getSocket().getOutboundRemaining() == 0;
14001402
}
14011403

1404+
14021405
@Override
14031406
protected void doWrite(boolean block, ByteBuffer buffer) throws IOException {
14041407
int n;

webapps/docs/changelog.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,12 @@
227227
being closed without a <code>GOAWAY</code> frame if an invalid
228228
<code>HEADERS</code> frame was received. (markt)
229229
</fix>
230+
<fix>
231+
<bug>69982</bug>: Fix a bug in the non-blocking flushing code for
232+
NIO+TLS that meant that a response may not be fully written until the
233+
connection is closed. Pull request <pr>966</pr> provided by Phil Clay.
234+
(markt)
235+
</fix>
230236
</changelog>
231237
</subsection>
232238
<subsection name="Jasper">

0 commit comments

Comments
 (0)