THRIFT-5905: Removed base64 and added logger as an explicit add_dependency #3245
+6
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


base64in Ruby 3.4Starting with Ruby 3.4,
base64is no longer a bundled gem, and now Thrift does not load in modern Ruby versions:Ruby already has ability to serialize and deserialize base64 without requiring the base64 gem, which is a thin wrapper for syntactic sugar.
loggerin Ruby 3.5Throws a warning at the moment, and will be an error in Ruby 3.5:
ostructin Ruby 3.5 (transitive dependency on Rake 12.x)Additionally, Rake used to use
ostruct, which will be removed in Ruby 4.0, and running tests produced the following warning:Updated Rake version to get rid of the warning and fix the gem for Ruby 4.0 (formerly known as 3.5)
Important
This is not enough to fix the gem for Ruby 3.5. Thrift currently only works with Rack 2, which also depends on
ostructwithout explicitly defining it (the usage was removed in Rack 3.1)Rack 3 support will require additional work.
[skip ci]anywhere in the commit message to free up build resources.