Skip to content

Commit 28389de

Browse files
sadpandajoeclauderusackas
authored
fix(ci): fix GHA for docs during PRs (#35186)
Co-authored-by: Claude <[email protected]> Co-authored-by: Evan Rusackas <[email protected]>
1 parent 7c415c7 commit 28389de

File tree

4 files changed

+62
-13
lines changed

4 files changed

+62
-13
lines changed

.github/workflows/superset-docs-verify.yml

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,14 @@ jobs:
2121
- uses: actions/checkout@v5
2222
# Do not bump this linkinator-action version without opening
2323
# an ASF Infra ticket to allow the new version first!
24-
- uses: JustinBeckwith/[email protected]
24+
- uses: JustinBeckwith/linkinator-action@3d5ba091319fa7b0ac14703761eebb7d100e6f6d # v1.11.0
2525
continue-on-error: true # This will make the job advisory (non-blocking, no red X)
2626
with:
27-
paths: "**/*.md, **/*.mdx, !superset-frontend/CHANGELOG.md"
27+
paths: "**/*.md, **/*.mdx"
2828
linksToSkip: >-
29-
^https://github.com/apache/(superset|incubator-superset)/(pull|issue)/\d+,
29+
^https://github.com/apache/(superset|incubator-superset)/(pull|issues)/\d+,
30+
^https://github.com/apache/(superset|incubator-superset)/commit/[a-f0-9]+,
31+
superset-frontend/.*CHANGELOG\.md,
3032
http://localhost:8088/,
3133
http://127.0.0.1:3000/,
3234
http://localhost:9001/,
@@ -41,12 +43,12 @@ jobs:
4143
http://theiconic.com.au/,
4244
https://dev.mysql.com/doc/refman/5.7/en/innodb-limits.html,
4345
^https://img\.shields\.io/.*,
44-
https://vkusvill.ru/
45-
https://www.linkedin.com/in/mark-thomas-b16751158/
46-
https://theiconic.com.au/
47-
https://wattbewerb.de/
48-
https://timbr.ai/
49-
https://opensource.org/license/apache-2-0
46+
https://vkusvill.ru/,
47+
https://www.linkedin.com/in/mark-thomas-b16751158/,
48+
https://theiconic.com.au/,
49+
https://wattbewerb.de/,
50+
https://timbr.ai/,
51+
https://opensource.org/license/apache-2-0,
5052
https://www.plaidcloud.com/
5153
build-deploy:
5254
name: Build & Deploy

docs/src/theme.d.ts

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
/**
2+
* Licensed to the Apache Software Foundation (ASF) under one
3+
* or more contributor license agreements. See the NOTICE file
4+
* distributed with this work for additional information
5+
* regarding copyright ownership. The ASF licenses this file
6+
* to you under the Apache License, Version 2.0 (the
7+
* "License"); you may not use this file except in compliance
8+
* with the License. You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
declare module '@theme/Layout' {
21+
import type { ReactNode } from 'react';
22+
23+
export interface Props {
24+
readonly children?: ReactNode;
25+
readonly noFooter?: boolean;
26+
readonly wrapperClassName?: string;
27+
readonly title?: string;
28+
readonly description?: string;
29+
}
30+
31+
export default function Layout(props: Props): ReactNode;
32+
}

docs/src/webpack.extend.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ import type { Plugin } from '@docusaurus/types';
2323
export default function webpackExtendPlugin(): Plugin<void> {
2424
return {
2525
name: 'custom-webpack-plugin',
26-
configureWebpack(config, isServer, utils) {
27-
const { isDev } = utils;
26+
configureWebpack(config) {
27+
const isDev = process.env.NODE_ENV === 'development';
2828
return {
2929
devtool: isDev ? 'eval-source-map' : config.devtool,
3030
...(isDev && {

docs/tsconfig.json

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,27 @@
22
// This file is not used in compilation. It is here just for a nice editor experience.
33
"extends": "@docusaurus/tsconfig",
44
"compilerOptions": {
5-
"baseUrl": "."
5+
"baseUrl": ".",
6+
"skipLibCheck": true,
7+
"noImplicitAny": false,
8+
"strict": false,
9+
"types": ["@docusaurus/module-type-aliases"]
610
},
711
"jsx": "react-jsx",
812
"moduleResolution": "node",
913
"baseUrl": "./",
1014
"paths": {
15+
"@superset-ui/core": ["../superset-frontend/packages/superset-ui-core/src"],
16+
"@superset-ui/core/*": ["../superset-frontend/packages/superset-ui-core/src/*"],
1117
"*": ["src/*", "node_modules/*"]
12-
}
18+
},
19+
"include": [
20+
"src/**/*.ts",
21+
"src/**/*.tsx"
22+
],
23+
"exclude": [
24+
"node_modules",
25+
"../superset-frontend/**/*",
26+
"src/webpack.extend.ts"
27+
]
1328
}

0 commit comments

Comments
 (0)