Skip to content

Commit 5826e8a

Browse files
committed
Remove duplicated addParameterMarkers while using SQLStatementCopyUtils.copyAttributes(...) and add unit tests for associated situations
1 parent 3cea05e commit 5826e8a

File tree

3 files changed

+556
-2
lines changed

3 files changed

+556
-2
lines changed

infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/engine/statement/ddl/CreateTableStatementBinder.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ private CreateTableStatement copy(final CreateTableStatement sqlStatement,
5757
result.setSelectStatement(boundSelectStatement);
5858
result.getColumnDefinitions().addAll(boundColumnDefinitions);
5959
result.getConstraintDefinitions().addAll(sqlStatement.getConstraintDefinitions());
60-
result.addParameterMarkers(sqlStatement.getParameterMarkers());
60+
// Remove duplicate addParameterMarkers call to avoid adding parameters twice
61+
// result.addParameterMarkers(sqlStatement.getParameterMarkers());
6162
result.setIfNotExists(sqlStatement.isIfNotExists());
6263
result.getColumns().addAll(sqlStatement.getColumns());
6364
sqlStatement.getLikeTable().ifPresent(result::setLikeTable);

infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/engine/statement/ddl/PrepareStatementBinder.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ private PrepareStatement copy(final PrepareStatement sqlStatement, final SelectS
5151
result.setInsert(boundInsert);
5252
result.setUpdate(boundUpdate);
5353
result.setDelete(boundDelete);
54-
result.addParameterMarkers(sqlStatement.getParameterMarkers());
54+
// Remove duplicate addParameterMarkers call to avoid adding parameters twice
55+
// result.addParameterMarkers(sqlStatement.getParameterMarkers());
5556
SQLStatementCopyUtils.copyAttributes(sqlStatement, result);
5657
return result;
5758
}

0 commit comments

Comments
 (0)