Skip to content

Commit baecbfa

Browse files
authored
DISPATCH-2363: chore(gha): change Python version to match Proton requirements; Proton main needs 3.9 or greater to compile (#1706)
1 parent fab69d9 commit baecbfa

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

.github/workflows/build.yaml

+8-4
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ jobs:
3737
ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
3838
DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
3939
InstallPrefix: ${{github.workspace}}/install
40+
# ternary in GHA: https://github.com/actions/runner/issues/409#issuecomment-752775072
41+
PythonVersion: "${{ matrix.protonGitRef == 'main' && 3.9 || 3.8 }}"
4042
VERBOSE: 1
4143

4244
ProtonCMakeExtraArgs: >
@@ -97,10 +99,10 @@ jobs:
9799
- name: Create Build and Install directories
98100
run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}" "${InstallPrefix}"
99101

100-
- name: Setup python
102+
- name: Setup python ${{ env.PythonVersion }}
101103
uses: actions/setup-python@v4
102104
with:
103-
python-version: 3.8
105+
python-version: ${{ env.PythonVersion }}
104106
architecture: x64
105107

106108
- name: Install Python build dependencies
@@ -184,6 +186,8 @@ jobs:
184186
ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
185187
DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
186188
InstallPrefix: ${{github.workspace}}/install
189+
# ternary in GHA: https://github.com/actions/runner/issues/409#issuecomment-752775072
190+
PythonVersion: "${{ matrix.protonGitRef == 'main' && 3.9 || 3.8 }}"
187191
# TODO(DISPATCH-2078) re-enable system_tests_authz_service_plugin when the GHA failure is understood and fixed
188192
DispatchCTestExtraArgs: "-E 'system_tests_authz_service_plugin'"
189193
LD_LIBRARY_PATH: ${{github.workspace}}/install/lib
@@ -200,10 +204,10 @@ jobs:
200204
with:
201205
name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}_${{matrix.runtimeCheck}}_${{matrix.protonGitRef}}
202206

203-
- name: Setup python
207+
- name: Setup python ${{ env.PythonVersion }}
204208
uses: actions/setup-python@v4
205209
with:
206-
python-version: 3.8
210+
python-version: ${{ env.PythonVersion }}
207211
architecture: x64
208212

209213
- name: Install Python runtime/test dependencies

0 commit comments

Comments
 (0)