fixup too many decrefs

Author: jiridanek

.travis.yml

@@ -126,6 +126,8 @@ addons:
     - sasl2-bin
     - swig
     - libnghttp2-dev
+    # used by symbolizer in leak warnings suppression
+    - python2.7-dbg
     # documentation
     - asciidoc
     - asciidoctor

src/router_pynode.c

@@ -444,9 +444,6 @@ qd_error_t qd_router_python_setup(qd_router_t *router)
     // Instantiate the router
     //
     pyRouter = PyObject_CallObject(pClass, pArgs);
-    Py_DECREF(pId);
-    Py_DECREF(pArea);
-    Py_DECREF(pMaxRouters);
     Py_DECREF(pClass);
     Py_DECREF(pArgs);
     Py_DECREF(adapterType);
@@ -456,7 +453,6 @@ qd_error_t qd_router_python_setup(qd_router_t *router)
     pySetMobileSeq   = PyObject_GetAttrString(pyRouter, "setMobileSeq"); QD_ERROR_PY_RET();
     pySetMyMobileSeq = PyObject_GetAttrString(pyRouter, "setMyMobileSeq"); QD_ERROR_PY_RET();
     pyLinkLost       = PyObject_GetAttrString(pyRouter, "linkLost"); QD_ERROR_PY_RET();
-//    Py_DECREF(adapterInstance);  // TODO: why not this? get python exceptions if I try
     return qd_error_code();
 }
 

tests/lsan.supp

@@ -37,7 +37,14 @@ leak:^pn_raw_connection$
 #### Miscellaneous 3rd party libraries:
 ####
 
-# these leaks happen even after simple Py_Initialize(); Py_Finalize();
+# Wholesale library suppressions, avoid doing this if at all possible
+#  one reason we may not be able to avoid doing this is compatibility with multiple versions of libs on many operating systems
+#leak:/libpython2.*.so
+#leak:/libpython3.*.so
+#leak:/libwebsockets.so
+#leak:libqpid-proton
+
+# these Python leaks happen even after simple Py_Initialize(); Py_Finalize();
 #  https://bugs.python.org/issue1635741
 leak:^_PyObject_Realloc
 leak:^PyObject_Malloc$
@@ -51,16 +58,23 @@ leak:^_PyObject_GC_Resize$
 # Python uses these alloc functions if you define PYTHONDEVMODE=1
 leak:^_PyMem_DebugRawAlloc$
 leak:^_PyMem_DebugRawRealloc$
+# All the rest
+leak:^list_append$
+leak:^list_resize$
+leak:^_PyBytes_Resize$
+leak:^resize_compact$
+leak:^unicode_resize$
+# Python 2.7
+leak:^PyString_FromStringAndSize$
+leak:^PyString_FromString$
+leak:^PyObject_Realloc$
+leak:^_PyObject_GC_Malloc$
+leak:^_PyString_Resize$
+leak:^PyUnicodeUCS4_FromUnicode$
+leak:^PyList_Append$
+leak:^PyList_New$
 
-# Wholesale library suppressions, avoid doing this if at all possible
-#  one reason we may not be able to avoid doing this is compatibility with multiple versions of libs on many operating systems
-leak:/libpython2.*.so
-#leak:/libpython3.*.so
-#leak:/libwebsockets.so
-#leak:libqpid-proton
-
-# We might be able to remove these once all known dispatch leaks have been fixed
-# Suppressions taken from Proton's lsan.supp
+# Proton suppressions taken from Proton's lsan.supp
 #  this appears in system_tests_open_properties:
 leak:^pni_data_grow$
 leak:^pn_buffer_ensure$