Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence model depends on public management API #780

Open
snazy opened this issue Jan 15, 2025 · 0 comments
Open

Persistence model depends on public management API #780

snazy opened this issue Jan 15, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@snazy
Copy link
Member

snazy commented Jan 15, 2025

Describe the bug

All entities of the persistence model have asXyz() functions to return a type from the management OpenAPI spec. While this is currently convenient, it introduces a cyclic dependency, which should generally be avoided:

  • management-API depends on REST endpoints
  • REST endpoint implementations depend on entities
  • entities depend on management-API

The management API and its implementation should not leak into the persistence model.

To Reproduce

No response

Actual Behavior

No response

Expected Behavior

No response

Additional context

No response

System information

No response

@snazy snazy added the bug Something isn't working label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant