Skip to content

Avoid using $page.base$ when loading the template assets and the assets.hostname is specified #128

@samueleresca

Description

@samueleresca

There are some static assets that are loaded by appending both the assets.hostname and the page.base. Few examples below:

  • $page.properties.("assets.hostname")$$page.base$$page.properties.("material.favicon")$
  • $page.properties.("assets.hostname")$$page.base$assets/javascripts/groups.js
  • $page.properties.("assets.hostname")$$page.base$assets/javascripts/application.583bbe55.js"

The examples provided lead to the following links in case the loaded page is in a subfolder:

  • https://pekko.apache.org/../assets/images/pekko_favicon.png
  • https://pekko.apache.org/../assets/javascripts/groups.js
  • https://pekko.apache.org/../assets/javascripts/application.583bbe55.js

Where page.base is ../ and assets.hostname is https://pekko.apache.org.

Note that the paths containing ../ are normalized by default (https://pekko.apache.org/../assets/images/pekko_favicon.png becomes https://pekko.apache.org/assets/images/pekko_favicon.png). Therefore, this issue is low priority because is not breaking resources.

This issue is for removing page.base from all the static assets loaded using the assets.hostname property

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions