Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Check that all fields with aggregate functions in partial-update should be protected by sequence-group #5034

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Feb 7, 2025

Purpose

For example,

CREATE TABLE SG
(
    pk   INT,
    f0   INT,
    g0   INT,
    f1   INT,
    g1   INT,
    PRIMARY KEY (pk) NOT ENFORCED
) WITH (
      'merge-engine' = 'partial-update',
      'fields.g0.sequence-group' = 'f0',
      'fields.f0.aggregate-function' = 'listagg',
      'fields.f1.aggregate-function' = 'listagg'
);

The f1 lack sequence-group but there's no exception.

Tests

API and Format

Documentation

yuzelin added 2 commits February 7, 2025 15:03
Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit bd9317e into apache:master Feb 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants