[core] Fix missing kotlin and okio dependencies when using okhttp3. #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerry-024 Here, it can only be 'okio-jvm' not 'okio', otherwise ut will not pass. |
|
This is the final version, production test or ut has passed. |
|
+1 |
jerry-024
reviewed
Feb 14, 2025
|
Need't add okio-jvm and kotlin-stdlib-jdk8 as dependency? |
No need. |
jerry-024
reviewed
Feb 14, 2025
| - com.squareup.okhttp3:okhttp:4.12.0 | ||
| - com.squareup.okio:okio-jvm:3.6.0 | ||
| - org.jetbrains.kotlin:kotlin-stdlib:1.8.21 |
There was a problem hiding this comment.
If we don't need add okio-jvm and kotlin-stdlib as dependency. Needn't update this file.
There was a problem hiding this comment.
It still bundles okio-jvm and kotlin-stdlib dependencies in this project, It's just that these two dependencies are introduced by okhttp3.
|
LGTM |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Relation pr : #5044 (this pr can't be reopen because force push.)
When I used the partition mark done action of
http-report:java. lang.NoClassDefFoundError: okio/Optionsjava. lang.NoClassDefFoundError: kotlin/jvm/internal/IntrinsicsSo we need to shade
okio-jvmandkotlin-stdlibtoo.Linked issue: close #xxx
Tests
API and Format
Documentation