Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix AppendOnlyWriterTest file format is error #5041

Merged
merged 1 commit into from
Feb 9, 2025
Merged

[test] Fix AppendOnlyWriterTest file format is error #5041

merged 1 commit into from
Feb 9, 2025

Conversation

gong
Copy link
Contributor

@gong gong commented Feb 8, 2025

Purpose

Linked issue: close #5040

Tests

 assertThat(meta.fileName().substring(meta.fileName().lastIndexOf(".") + 1))
                .isEqualTo(CoreOptions.FILE_FORMAT_AVRO);

API and Format

No change

Documentation

No change

@gong
Copy link
Contributor Author

gong commented Feb 8, 2025

@JingsongLi @yuzelin PTAL

JingsongLi
JingsongLi approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit a01f007 into apache:master Feb 9, 2025
12 checks passed
JackeyLee007 pushed a commit to JackeyLee007/paimon that referenced this pull request Feb 14, 2025
@gong
[test] Fix AppendOnlyWriterTest file format is error (apache#5041)
0aa74f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] AppendOnlyWriterTest test error, specific file format is avro, but generate file suffix is parquet
2 participants
@gong @JingsongLi