[core] Slightly refatory code in LookupChangelogMergeFunctionWrapper #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
changed the title
JingsongLi
reviewed
Feb 10, 2025
| @@ -195,4 +205,23 @@ public static String rowDataToString(InternalRow row, RowType type) { | |||
| .getFieldOrNull(row))) | |||
| .collect(Collectors.joining(", ")); | |||
| } | |||
|
|
|||
| /** Copier for KeyValue. */ | |||
| public static class KeyValueCopier { | |||
JingsongLi
reviewed
Feb 10, 2025
| @@ -68,6 +67,9 @@ public class LookupChangelogMergeFunctionWrapper<T> | |||
| private final @Nullable DeletionVectorsMaintainer deletionVectorsMaintainer; | |||
| private final Comparator<KeyValue> comparator; | |||
|
|
|||
| private final LinkedList<KeyValue> candidates = new LinkedList<>(); | |||
| private final KeyValue.KeyValueCopier keyValueCopier; | |||
There was a problem hiding this comment.
Just store keySerializer and valueSerializer here.
|
+1 |
1 similar comment
|
+1 |
JackeyLee007
pushed a commit
to JackeyLee007/paimon
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We don't need two merge functions in one
LookupChangelogMergeFunctionWrapperTests
API and Format
Documentation