[core] FileBasedBloomFilter should not be pass private member to cache manager. #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
changed the title
JingsongLi
reviewed
Sep 3, 2024
paimon-common/src/main/java/org/apache/paimon/utils/FileBasedBloomFilter.java
Outdated
Show resolved
Hide resolved
|
+1 |
wxplovecc
pushed a commit
to tongcheng-elong/incubator-paimon
that referenced
this pull request
Sep 10, 2024
…e manager. (apache#4118) (cherry picked from commit 3ce8fda)
|
Hi @leaves12138 , why this will lead to out of memory ? |
If we use lambda, the member "filter" will be indexed. The instance which contains the "filter" will also be referred, cannot gc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Cache manager cause out of memory while lookup merge
Tests
API and Format
Documentation