Fixes most layer position warnings and improved logging

mbien · mbien · commit cfe70c4d7904 · 2025-10-15T05:01:26.000+02:00
The warning message will now include the position of the services
to make picking a value easier.

Tested activation of all clusters and maven project creation, only one
root '/' warning is left to fix in the log.

Might make the layer behave more deterministic in some cases.

conflict fixes:

RecursiveDiffAction -&gt; 250
same position 300 for both 
UI/ToolActions/Files/org-netbeans-modules-diff-tree-RecursiveDiffAction.shadow and 
UI/ToolActions/Files/org-netbeans-modules-favorites-Add.shadow

Native -&gt; 660
same position 650 for both Templates/Project/GradleGroovy and Templates/Project/Native

ordering fixes:

TextToolsTopComponent -&gt; 3400
Not all children in Windows2/Modes/output/ marked with the position attribute: 
[TextToolsTopComponent.wstcref], but some are: 
[watchesView.wstcref, NotificationCenterTopComponent.wstcref, ...]

InlineHints -&gt; 0
Not all children in OptionsDialog/Editor/ marked with the position attribute: 
[InlineHints], but some are: 
[CodeCompletion, Formatting, Hints, MarkOccurrences, ...]

CoverageReportTopComponent -&gt; 0
TreeDiffViewerTopComponent -&gt; 0
Not all children in Windows2/Modes/editor/ marked with the position attribute: 
[TreeDiffViewerTopComponent.wstcref, CoverageReportTopComponent.wstcref], but some are: 
[DashboardDisplayer.wstcref]

settings.xml -&gt; 110
Not all children in Templates/Project/Maven2/ marked with the position attribute:
[settings.xml], but some are:
[JavaApp, org-netbeans-modules-maven-j2ee-ui-wizard-EEWizardIterator-createWebAppIterator, ...]

CompletionProviderImpl -&gt; 1000
Not all children in / marked with the position attribute:
[org-netbeans-modules-lsp-client-bindings-CompletionProviderImpl.instance], but some are:
[org-netbeans-modules-editor-java-JavaCompletionProvider.instance, ...]

WordCompletion -&gt; 600 (across several layer registrations)
Not all children in / marked with the position attribute:
[org-netbeans-modules-spellchecker-completion-WordCompletion.instance], but some are:
[org-netbeans-modules-lsp-client-bindings-CompletionProviderImpl.instance@1000]
diff --git a/cpplite/cpplite.project/src/org/netbeans/modules/cpplite/project/layer.xml b/cpplite/cpplite.project/src/org/netbeans/modules/cpplite/project/layer.xml
@@ -24,7 +24,7 @@
     <folder name="Templates">
         <folder name="Project">
             <folder name="Native">
-                <attr name="position" intvalue="650"/>
+                <attr name="position" intvalue="660"/>
                 <attr name="displayName" bundlevalue="org.netbeans.modules.cpplite.project.Bundle#CPPLite_NewProject" />
             </folder>
         </folder>
diff --git a/ide/diff/src/org/netbeans/modules/diff/tree/RecursiveDiffAction.java b/ide/diff/src/org/netbeans/modules/diff/tree/RecursiveDiffAction.java
@@ -46,7 +46,7 @@
 )
 @ActionReference(
     path = "UI/ToolActions/Files",
-    position = 300
+    position = 250
 )
 @Messages("CTL_RecursiveDiffAction=Tree diff")
 public final class RecursiveDiffAction extends NodeAction implements ActionListener {
diff --git a/ide/diff/src/org/netbeans/modules/diff/tree/TreeDiffViewerTopComponent.java b/ide/diff/src/org/netbeans/modules/diff/tree/TreeDiffViewerTopComponent.java
@@ -63,7 +63,8 @@
 )
 @TopComponent.Registration(
         mode = "editor",
-        openAtStartup = false
+        openAtStartup = false,
+        position = 0
 )
 @Messages({
     "CTL_TreeDiffViewerTopComponent=Tree diff",
diff --git a/ide/gsf.codecoverage/src/org/netbeans/modules/gsf/codecoverage/layer.xml b/ide/gsf.codecoverage/src/org/netbeans/modules/gsf/codecoverage/layer.xml
@@ -36,7 +36,9 @@
     <folder name="Windows2">
         <folder name="Modes">
             <folder name="editor">
-                <file name="CoverageReportTopComponent.wstcref" url="CoverageReportTopComponentWstcref.xml"/>
+                <file name="CoverageReportTopComponent.wstcref" url="CoverageReportTopComponentWstcref.xml">
+                    <attr name="position" intvalue="0"/>
+                </file>
             </folder>
         </folder>
     </folder>
diff --git a/ide/lsp.client/src/org/netbeans/modules/lsp/client/bindings/CompletionProviderImpl.java b/ide/lsp.client/src/org/netbeans/modules/lsp/client/bindings/CompletionProviderImpl.java
@@ -87,7 +87,7 @@
  *
  * @author lahvac
  */
-@MimeRegistration(mimeType="", service=CompletionProvider.class)
+@MimeRegistration(mimeType="", service=CompletionProvider.class, position = 1000)
 public class CompletionProviderImpl implements CompletionProvider {
 
     private static final Logger LOG = Logger.getLogger(CompletionProviderImpl.class.getName());
diff --git a/ide/spellchecker.bindings.htmlxml/src/org/netbeans/modules/spellchecker/bindings/htmlxml/layer.xml b/ide/spellchecker.bindings.htmlxml/src/org/netbeans/modules/spellchecker/bindings/htmlxml/layer.xml
@@ -28,55 +28,71 @@
                     <file name="org-netbeans-modules-spellchecker-bindings-htmlxml-HtmlXmlTokenListProvider.instance" />
                 </folder>
                 <folder name="CompletionProviders">
-                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance"/>
+                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance">
+                        <attr name="position" intvalue="600"/>
+                    </file>
                 </folder>
             </folder>
             <folder name="xhtml">
                 <folder name="TokenListProvider">
                     <file name="org-netbeans-modules-spellchecker-bindings-htmlxml-HtmlXmlTokenListProvider.instance" />
                 </folder>
                 <folder name="CompletionProviders">
-                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance"/>
+                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance">
+                        <attr name="position" intvalue="600"/>
+                    </file>
                 </folder>
             </folder>
             <folder name="x-php5">
                 <folder name="TokenListProvider">
                     <file name="org-netbeans-modules-spellchecker-bindings-htmlxml-HtmlXmlTokenListProvider.instance" />
                 </folder>
                 <folder name="CompletionProviders">
-                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance"/>
+                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance">
+                        <!-- none of the php completion poviders have currently a position
+                        <attr name="position" intvalue="600"/>
+                        -->
+                    </file>
                 </folder>
             </folder>
             <folder name="x-jsp">
                 <folder name="TokenListProvider">
                     <file name="org-netbeans-modules-spellchecker-bindings-htmlxml-HtmlXmlTokenListProvider.instance" />
                 </folder>
                 <folder name="CompletionProviders">
-                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance"/>
+                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance">
+                        <attr name="position" intvalue="600"/>
+                    </file>
                 </folder>
             </folder>
             <folder name="x-tag">
                 <folder name="TokenListProvider">
                     <file name="org-netbeans-modules-spellchecker-bindings-htmlxml-HtmlXmlTokenListProvider.instance" />
                 </folder>
                 <folder name="CompletionProviders">
-                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance"/>
+                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance">
+                        <attr name="position" intvalue="600"/>
+                    </file>
                 </folder>
             </folder>
             <folder name="x-gsp">
                 <folder name="TokenListProvider">
                     <file name="org-netbeans-modules-spellchecker-bindings-htmlxml-HtmlXmlTokenListProvider.instance" />
                 </folder>
                 <folder name="CompletionProviders">
-                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance"/>
+                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance">
+                        <attr name="position" intvalue="600"/>
+                    </file>
                 </folder>
             </folder>
             <folder name="xml">
                 <folder name="TokenListProvider">
                     <file name="org-netbeans-modules-spellchecker-bindings-htmlxml-HtmlXmlTokenListProvider.instance" />
                 </folder>
                 <folder name="CompletionProviders">
-                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance"/>
+                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance">
+                        <attr name="position" intvalue="600"/>
+                    </file>
                 </folder>
             </folder>
         </folder>
diff --git a/ide/spellchecker.bindings.properties/src/org/netbeans/modules/spellchecker/bindings/properties/layer.xml b/ide/spellchecker.bindings.properties/src/org/netbeans/modules/spellchecker/bindings/properties/layer.xml
@@ -28,7 +28,9 @@
                     <file name="org-netbeans-modules-spellchecker-bindings-properties-PropertiesTokenListProvider.instance" />
                 </folder>
                 <folder name="CompletionProviders">
-                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance"/>
+                    <file name="org-netbeans-modules-spellchecker-completion-WordCompletion.instance">
+                        <attr name="position" intvalue="600"/>
+                    </file>
                 </folder>
             </folder>
         </folder>
diff --git a/ide/texttools/src/org/netbeans/modules/texttools/TextToolsTopComponent.java b/ide/texttools/src/org/netbeans/modules/texttools/TextToolsTopComponent.java
@@ -70,7 +70,7 @@
     iconBase="org/netbeans/modules/texttools/accessories-text-editor.png",
     persistenceType = TopComponent.PERSISTENCE_ONLY_OPENED
 )
-@TopComponent.Registration(mode = "output", openAtStartup = false)
+@TopComponent.Registration(mode = "output", openAtStartup = false, position = 3400)
 @Messages({
     "CTL_TextToolsAction=Text Tools",
     "CTL_TextToolsTopComponent=Text Tools Window",
diff --git a/java/java.editor/src/org/netbeans/modules/java/editor/resources/layer.xml b/java/java.editor/src/org/netbeans/modules/java/editor/resources/layer.xml
@@ -448,6 +448,7 @@
                 </folder>
             </folder>
             <folder name="InlineHints">
+                <attr name="position" intvalue="0"/>
                 <folder name="text">
                     <folder name="x-java">
                         <file name="JavaInlineHints.instance">
diff --git a/java/maven/src/org/netbeans/modules/maven/layer.xml b/java/maven/src/org/netbeans/modules/maven/layer.xml
@@ -53,6 +53,7 @@
                 <file name="settings.xml" url="settings.template.xml">
                     <attr name="javax.script.ScriptEngine" stringvalue="freemarker"/>
                     <attr name="template.openFile" boolvalue="false"/>
+                    <attr name="position" intvalue="110"/>
                 </file>
             </folder>
         </folder>
diff --git a/platform/openide.filesystems/src/org/openide/filesystems/Ordering.java b/platform/openide.filesystems/src/org/openide/filesystems/Ordering.java
@@ -201,7 +201,7 @@ public int compareTo(ChildAndPosition o) {
                     if (n.contains("ergonomics")) { // NOI18N
                         break IGNORE_ERGO;
                     }
-                    presentNames.add(n);
+                    presentNames.add(n + "@" + cap.position);
                 }
                 LOG.log(
                     Level.WARNING, "Not all children in {0}/ marked with the position attribute: {1}, but some are: {2}",

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@`
`46`	`46`	`)`
`47`	`47`	`@ActionReference(`
`48`	`48`	`path = "UI/ToolActions/Files",`
`49`		`- position = 300`
	`49`	`+ position = 250`
`50`	`50`	`)`
`51`	`51`	`@Messages("CTL_RecursiveDiffAction=Tree diff")`
`52`	`52`	`public final class RecursiveDiffAction extends NodeAction implements ActionListener {`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,8 @@`
`63`	`63`	`)`
`64`	`64`	`@TopComponent.Registration(`
`65`	`65`	`mode = "editor",`
`66`		`- openAtStartup = false`
	`66`	`+ openAtStartup = false,`
	`67`	`+ position = 0`
`67`	`68`	`)`
`68`	`69`	`@Messages({`
`69`	`70`	`"CTL_TreeDiffViewerTopComponent=Tree diff",`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@`
`87`	`87`	`*`
`88`	`88`	`* @author lahvac`
`89`	`89`	`*/`
`90`		`-@MimeRegistration(mimeType="", service=CompletionProvider.class)`
	`90`	`+@MimeRegistration(mimeType="", service=CompletionProvider.class, position = 1000)`
`91`	`91`	`public class CompletionProviderImpl implements CompletionProvider {`
`92`	`92`
`93`	`93`	`private static final Logger LOG = Logger.getLogger(CompletionProviderImpl.class.getName());`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@`
`70`	`70`	`iconBase="org/netbeans/modules/texttools/accessories-text-editor.png",`
`71`	`71`	`persistenceType = TopComponent.PERSISTENCE_ONLY_OPENED`
`72`	`72`	`)`
`73`		`-@TopComponent.Registration(mode = "output", openAtStartup = false)`
	`73`	`+@TopComponent.Registration(mode = "output", openAtStartup = false, position = 3400)`
`74`	`74`	`@Messages({`
`75`	`75`	`"CTL_TextToolsAction=Text Tools",`
`76`	`76`	`"CTL_TextToolsTopComponent=Text Tools Window",`