Replace JUnit 4 parameterised tests with subclasses that override the constructor of DefaultRouteScriptAppenderTest

Author: jcoglan

log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/routing/DefaultRouteScriptAppenderTest.java

@@ -32,26 +32,11 @@
 import org.junit.BeforeClass;
 import org.junit.Rule;
 import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
 
 /**
  *
  */
-@RunWith(Parameterized.class)
-public class DefaultRouteScriptAppenderTest {
-
-    @Parameterized.Parameters(name = "{0} {1}")
-    public static Object[][] getParameters() {
-        // @formatter:off
-        return new Object[][] {
-            {"log4j-routing-default-route-script-groovy.xml", false},
-            {"log4j-routing-default-route-script-javascript.xml", false},
-            {"log4j-routing-script-staticvars-javascript.xml", true},
-            {"log4j-routing-script-staticvars-groovy.xml", true},
-        };
-        // @formatter:on
-    }
+public abstract class DefaultRouteScriptAppenderTest {
 
     @BeforeClass
     public static void beforeClass() {

log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/routing/DefaultRouteScriptGroovyAppenderTest.java

@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.logging.log4j.core.appender.routing;
+
+public class DefaultRouteScriptGroovyAppenderTest extends DefaultRouteScriptAppenderTest {
+    public DefaultRouteScriptGroovyAppenderTest() {
+        super("log4j-routing-default-route-script-groovy.xml", false);
+    }
+}

log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/routing/DefaultRouteScriptJavaScriptAppenderTest.java

@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.logging.log4j.core.appender.routing;
+
+public class DefaultRouteScriptJavaScriptAppenderTest extends DefaultRouteScriptAppenderTest {
+    public DefaultRouteScriptJavaScriptAppenderTest() {
+        super("log4j-routing-default-route-script-javascript.xml", false);
+    }
+}

log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/routing/ScriptStaticVarsGroovyAppenderTest.java

@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.logging.log4j.core.appender.routing;
+
+public class ScriptStaticVarsGroovyAppenderTest extends DefaultRouteScriptAppenderTest {
+    public ScriptStaticVarsGroovyAppenderTest() {
+        super("log4j-routing-script-staticvars-groovy.xml", true);
+    }
+}

log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/routing/ScriptStaticVarsJavaScriptAppenderTest.java

@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.logging.log4j.core.appender.routing;
+
+public class ScriptStaticVarsJavaScriptAppenderTest extends DefaultRouteScriptAppenderTest {
+    public ScriptStaticVarsJavaScriptAppenderTest() {
+        super("log4j-routing-script-staticvars-javascript.xml", true);
+    }
+}