feat: Make some REST methods public #922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I'm a bit concerned about this since it's really an internal implementation detail that we don't want to expose.
Does it make more sense to allow table metadata to be partially parsed? I'm happy to discuss this direction if you are willing to establish an issue for it. |
|
Thanks for your response! I ended up taking a different direction that does not use Iceberg, so I'll be closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorResponse,OK, andHttpClientpublic to support escape-hatching for REST catalogs that don't 100% support the iceberg catalog response formats.I'd like to use
iceberg-rustfor some Iceberg-like clients that return partialTableMetadataresponses, so I need to be able to access the underlying HTTP client to set my own response types. This enables that use case, and lets me re-use all of the nice work around endpoints, HTTP clients, etc.