Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Extract partition_filters out of ManifestEvaluator #359

Closed
marvinlanhenke opened this issue Apr 28, 2024 · 1 comment · Fixed by #360
Closed

Refactor: Extract partition_filters out of ManifestEvaluator #359

marvinlanhenke opened this issue Apr 28, 2024 · 1 comment · Fixed by #360
Assignees

Comments

@marvinlanhenke
Copy link
Contributor

Problem:

  1. The partition_filter is also required by the ExpressionEvaluator; thus should be moved outside ManifestEvaluator; cached by spec_id in scan.rs and then used by ExpressionEvaluator as well as the ManifestEvaluator
  2. Also fn create_manifest_evaluator + ManifestEvaluator::new both do some setup work; here I'd propose to move the setup code completely into fn create_manifest_evaluator and avoid splitting the setup over mutliple places
@marvinlanhenke
Copy link
Contributor Author

I also like to work on this one; since it kind of blocks #358.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant