You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The partition_filter is also required by the ExpressionEvaluator; thus should be moved outside ManifestEvaluator; cached by spec_id in scan.rs and then used by ExpressionEvaluator as well as the ManifestEvaluator
Also fn create_manifest_evaluator + ManifestEvaluator::new both do some setup work; here I'd propose to move the setup code completely into fn create_manifest_evaluator and avoid splitting the setup over mutliple places
The text was updated successfully, but these errors were encountered:
Problem:
partition_filter
is also required by the ExpressionEvaluator; thus should be moved outside ManifestEvaluator; cached by spec_id in scan.rs and then used by ExpressionEvaluator as well as the ManifestEvaluatorfn create_manifest_evaluator
+ManifestEvaluator::new
both do some setup work; here I'd propose to move the setup code completely into fn create_manifest_evaluator and avoid splitting the setup over mutliple placesThe text was updated successfully, but these errors were encountered: