Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate snapshot-id of SetStatisticsUpdate #1556

Open
kevinjqliu opened this issue Jan 21, 2025 · 4 comments · May be fixed by #1566
Open

Deprecate snapshot-id of SetStatisticsUpdate #1556

kevinjqliu opened this issue Jan 21, 2025 · 4 comments · May be fixed by #1566
Assignees
@ndrluis

Comments

@kevinjqliu
Copy link
Contributor

Feature Request / Improvement

Following the discussion on the Mailing List:
https://lists.apache.org/thread/phxjz196zbzg0fjpfkmnj0fpkshgh9z0

Java implementation PR: OpenAPI: Deprecate snapshot-id of SetStatisticsUpdate apache/iceberg#12010

Updating table stats in pyiceberg was implemented in #1285, let's match the deprecation
@kevinjqliu
Copy link
Contributor Author

iceberg-python/pyiceberg/table/update/statistics.py

Lines 55 to 61 in 3981e62

def set_statistics(self, snapshot_id: int, statistics_file: StatisticsFile) -> "UpdateStatistics":
self._updates += (
SetStatisticsUpdate(
snapshot_id=snapshot_id,
statistics=statistics_file,
),
)

@ndrluis
Copy link
Collaborator

ndrluis commented Jan 22, 2025

@kevinjqliu Since we haven't released a version with snapshot_id yet, could we just remove it? What do you think?

@kevinjqliu
Copy link
Contributor Author

@ndrluis oh yea, good catch! lets do that then

@ndrluis
Copy link
Collaborator

ndrluis commented Jan 22, 2025

ok I can help with this!

@ndrluis ndrluis self-assigned this Jan 22, 2025
@ndrluis ndrluis linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndrluis ndrluis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant snapshot_id from SetStatisticsUpdate ndrluis/iceberg-python
2 participants
@ndrluis @kevinjqliu