Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InMemoryCatalog from the test-codebase #1110

Open
Fokko opened this issue Aug 28, 2024 · 2 comments · May be fixed by #1140
Open

Remove InMemoryCatalog from the test-codebase #1110

Fokko opened this issue Aug 28, 2024 · 2 comments · May be fixed by #1140
Labels
good first issue Good for newcomers

Comments

@Fokko
Copy link
Contributor

Fokko commented Aug 28, 2024

Feature Request / Improvement

InMemoryCatalog can be replaced by the SqlCatalog with Sqlite as a backend. Less code is more :)

@ndrluis ndrluis added the good first issue Good for newcomers label Aug 29, 2024
@kevinjqliu
Copy link
Contributor

perhaps its a good idea to alias a new InMemoryCatalog implementation using SqlCatalog
such as

props = {
"uri": "sqlite:///:memory:",
"warehouse": f"file://{warehouse}",
}
catalog = SqlCatalog(catalog_name, **props)

@hussein-awala
Copy link
Member

@Fokko I agree with @kevinjqliu on the alias proposition, I implemented #1140 which makes InMemoryCatalog a subclass of SqlCatalog, and overrides some methods to simplify the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants