Skip to content

Commit cad427a

Browse files
committed
resolve conflicts
1 parent 76b4949 commit cad427a

File tree

1 file changed

+23
-16
lines changed

1 file changed

+23
-16
lines changed

pyiceberg/table/__init__.py

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2481,13 +2481,13 @@ def _dataframe_to_data_files(
24812481
yield from write_file(io=io, table_metadata=table_metadata, tasks=iter([WriteTask(write_uuid, next(counter), df)]))
24822482

24832483

2484-
class _SnapshotProducer(UpdateTableMetadata["_MergingSnapshotProducer"]):
2484+
class _SnapshotProducer(UpdateTableMetadata["_SnapshotProducer"]):
24852485
commit_uuid: uuid.UUID
2486+
_io: FileIO
24862487
_operation: Operation
24872488
_snapshot_id: int
24882489
_parent_snapshot_id: Optional[int]
24892490
_added_data_files: List[DataFile]
2490-
_transaction: Optional[Transaction]
24912491
_manifest_num_counter: itertools.count[int]
24922492

24932493
def __init__(
@@ -2507,7 +2507,6 @@ def __init__(
25072507
snapshot.snapshot_id if (snapshot := self._transaction.table_metadata.current_snapshot()) else None
25082508
)
25092509
self._added_data_files = []
2510-
self._transaction = transaction
25112510
self._manifest_num_counter = itertools.count(0)
25122511

25132512
def append_data_file(self, data_file: DataFile) -> _SnapshotProducer:
@@ -2646,26 +2645,28 @@ def snapshot_id(self) -> int:
26462645
return self._snapshot_id
26472646

26482647
def spec(self, spec_id: int) -> PartitionSpec:
2649-
return self._table.specs()[spec_id]
2648+
return self._transaction.table_metadata.specs()[spec_id]
26502649

26512650
def new_manifest_writer(self, spec: PartitionSpec) -> ManifestWriter:
26522651
return write_manifest(
2653-
format_version=self._table.format_version,
2652+
format_version=self._transaction.table_metadata.format_version,
26542653
spec=spec,
2655-
schema=self._table.schema(),
2654+
schema=self._transaction.table_metadata.schema(),
26562655
output_file=self.new_manifest_output(),
26572656
snapshot_id=self._snapshot_id,
26582657
)
26592658

26602659
def new_manifest_output(self) -> OutputFile:
2661-
return self._table.io.new_output(
2660+
return self._io.new_output(
26622661
_new_manifest_path(
2663-
location=self._table.location(), num=next(self._manifest_num_counter), commit_uuid=self.commit_uuid
2662+
location=self._transaction.table_metadata.location,
2663+
num=next(self._manifest_num_counter),
2664+
commit_uuid=self.commit_uuid,
26642665
)
26652666
)
26662667

26672668
def fetch_manifest_entry(self, manifest: ManifestFile, discard_deleted: bool = True) -> List[ManifestEntry]:
2668-
return manifest.fetch_manifest_entry(io=self._table.io, discard_deleted=discard_deleted)
2669+
return manifest.fetch_manifest_entry(io=self._io, discard_deleted=discard_deleted)
26692670

26702671

26712672
class AppendFiles(_SnapshotProducer, ABC):
@@ -2699,19 +2700,25 @@ class MergeAppendFiles(AppendFiles):
26992700
def __init__(
27002701
self,
27012702
operation: Operation,
2702-
table: Table,
2703+
transaction: Transaction,
2704+
io: FileIO,
27032705
commit_uuid: Optional[uuid.UUID] = None,
2704-
transaction: Optional[Transaction] = None,
27052706
) -> None:
2706-
super().__init__(operation, table, commit_uuid, transaction)
2707+
super().__init__(operation, transaction, io, commit_uuid)
27072708
self._target_size_bytes = PropertyUtil.property_as_int(
2708-
self._table.properties, TableProperties.MANIFEST_TARGET_SIZE_BYTES, TableProperties.MANIFEST_TARGET_SIZE_BYTES_DEFAULT
2709+
self._transaction.table_metadata.properties,
2710+
TableProperties.MANIFEST_TARGET_SIZE_BYTES,
2711+
TableProperties.MANIFEST_TARGET_SIZE_BYTES_DEFAULT,
27092712
) # type: ignore
27102713
self._min_count_to_merge = PropertyUtil.property_as_int(
2711-
self._table.properties, TableProperties.MANIFEST_MIN_MERGE_COUNT, TableProperties.MANIFEST_MIN_MERGE_COUNT_DEFAULT
2714+
self._transaction.table_metadata.properties,
2715+
TableProperties.MANIFEST_MIN_MERGE_COUNT,
2716+
TableProperties.MANIFEST_MIN_MERGE_COUNT_DEFAULT,
27122717
) # type: ignore
27132718
self._merge_enabled = PropertyUtil.property_as_bool(
2714-
self._table.properties, TableProperties.MANIFEST_MERGE_ENABLED, TableProperties.MANIFEST_MERGE_ENABLED_DEFAULT
2719+
self._transaction.table_metadata.properties,
2720+
TableProperties.MANIFEST_MERGE_ENABLED,
2721+
TableProperties.MANIFEST_MERGE_ENABLED_DEFAULT,
27152722
)
27162723

27172724
def _deleted_entries(self) -> List[ManifestEntry]:
@@ -2804,7 +2811,7 @@ def fast_append(self) -> FastAppendFiles:
28042811
return FastAppendFiles(operation=Operation.APPEND, transaction=self._transaction, io=self._io)
28052812

28062813
def merge_append(self) -> MergeAppendFiles:
2807-
return MergeAppendFiles(table=self._table, operation=Operation.APPEND, transaction=self._transaction)
2814+
return MergeAppendFiles(operation=Operation.APPEND, transaction=self._transaction, io=self._io)
28082815

28092816
def overwrite(self) -> OverwriteFiles:
28102817
return OverwriteFiles(

0 commit comments

Comments
 (0)