Only relevant changes

Author: mariotaddeucci

pyiceberg/table/update/schema.py

@@ -174,13 +174,7 @@ def union_by_name(self, new_schema: Union[Schema, "pa.Schema"]) -> UpdateSchema:
         )
         return self
 
-    def add_column(
-        self,
-        path: Union[str, Tuple[str, ...]],
-        field_type: IcebergType,
-        doc: Optional[str] = None,
-        required: bool = False,
-    ) -> UpdateSchema:
+    def add_column(self, path: Union[str, Tuple[str, ...]], field_type: IcebergType, doc: Optional[str] = None, required: bool = False) -> UpdateSchema:
         """Add a new column to a nested struct or Add a new top-level column.
 
         Because "." may be interpreted as a column path separator or may be used in field names, it

tests/test_schema.py

@@ -1659,15 +1659,15 @@ def test_overwrite_schema() -> None:
     base_schema = Schema(NestedField(field_id=1, name="old", field_type=StringType(), required=True))
 
     schema = Schema(
-        NestedField(field_id=1, name="foo", field_type=StringType(), required=False),
+        NestedField(field_id=1, name="foo", field_type=StringType(), required=True),
         NestedField(field_id=2, name="bar", field_type=IntegerType(), required=False),
         NestedField(field_id=3, name="baz", field_type=BooleanType(), required=False),
     )
 
     new_schema = UpdateSchema(transaction=None, schema=base_schema).overwrite(schema)._apply()  # type: ignore
 
     expected_schema = Schema(
-        NestedField(field_id=2, name="foo", field_type=StringType(), required=False),
+        NestedField(field_id=2, name="foo", field_type=StringType(), required=True),
         NestedField(field_id=3, name="bar", field_type=IntegerType(), required=False),
         NestedField(field_id=4, name="baz", field_type=BooleanType(), required=False),
     )
@@ -1680,7 +1680,7 @@ def test_overwrite_with_pa_schema() -> None:
 
     pa_schema = pa.schema(
         [
-            pa.field("foo", pa.string(), nullable=True),
+            pa.field("foo", pa.string(), nullable=False),
             pa.field("bar", pa.int32(), nullable=True),
             pa.field("baz", pa.bool_(), nullable=True),
         ]
@@ -1689,7 +1689,7 @@ def test_overwrite_with_pa_schema() -> None:
     new_schema = UpdateSchema(transaction=None, schema=base_schema).overwrite(pa_schema)._apply()  # type: ignore
 
     expected_schema = Schema(
-        NestedField(field_id=2, name="foo", field_type=StringType(), required=False),
+        NestedField(field_id=2, name="foo", field_type=StringType(), required=True),
         NestedField(field_id=3, name="bar", field_type=IntegerType(), required=False),
         NestedField(field_id=4, name="baz", field_type=BooleanType(), required=False),
     )