fixup! Deprecate rest.authorization-url in favor of oauth2-server-uri

Author: ndrluis

mkdocs/docs/how-to-release.md

@@ -40,6 +40,14 @@ For example, the API with the following deprecation tag should be removed when p
 
 We also have the `deprecation_message` function. We need to change the behavior according to what is noted in the message of that deprecation.
 
+```python
+deprecation_message(
+    deprecated_in="0.1.0",
+    removed_in="0.2.0",
+    help_message="The old_property is deprecated. Please use the something_else property instead.",
+)
+```
+
 ## Running a release candidate
 
 Make sure that the version is correct in `pyproject.toml` and `pyiceberg/__init__.py`. Correct means that it reflects the version that you want to release.

pyiceberg/utils/deprecated.py

@@ -30,14 +30,10 @@ def deprecated(deprecated_in: str, removed_in: str, help_message: Optional[str]
     def decorator(func: Callable):  # type: ignore
         @functools.wraps(func)
         def new_func(*args: Any, **kwargs: Any) -> Any:
-            warnings.simplefilter("always", DeprecationWarning)  # turn off filter
-
-            warnings.warn(
-                f"Call to {func.__name__}, deprecated in {deprecated_in}, will be removed in {removed_in}.{help_message}",
-                category=DeprecationWarning,
-                stacklevel=2,
-            )
-            warnings.simplefilter("default", DeprecationWarning)  # reset filter
+            message = f"Call to {func.__name__}, deprecated in {deprecated_in}, will be removed in {removed_in}.{help_message}"
+
+            _deprecation_warning(message)
+
             return func(*args, **kwargs)
 
         return new_func
@@ -46,14 +42,20 @@ def new_func(*args: Any, **kwargs: Any) -> Any:
 
 
 def deprecation_message(deprecated_in: str, removed_in: str, help_message: Optional[str]) -> None:
-    """Mark properties as deprecated.
+    """Mark properties or behaviors as deprecated.
 
-    Adding this will result in a warning being emitted when the property is used.
+    Adding this will result in a warning being emitted.
     """
+    message = f"Deprecated in {deprecated_in}, will be removed in {removed_in}. {help_message}"
+
+    _deprecation_warning(message)
+
+
+def _deprecation_warning(message: str) -> None:
     warnings.simplefilter("always", DeprecationWarning)  # turn off filter
 
     warnings.warn(
-        f"Deprecated in {deprecated_in}, will be removed in {removed_in}. {help_message}",
+        message,
         category=DeprecationWarning,
         stacklevel=2,
     )