From 9980b3910e9abecb3d34d1b0c68fec44694238dc Mon Sep 17 00:00:00 2001 From: Sreesh Maheshwar Date: Sat, 11 Jan 2025 23:33:00 +0000 Subject: [PATCH] Nit: Add asserts for table properties defaults as well as comment in test --- tests/integration/test_writes/test_partitioned_writes.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/integration/test_writes/test_partitioned_writes.py b/tests/integration/test_writes/test_partitioned_writes.py index 2b68fefa51..9e7632852c 100644 --- a/tests/integration/test_writes/test_partitioned_writes.py +++ b/tests/integration/test_writes/test_partitioned_writes.py @@ -294,10 +294,12 @@ def test_object_storage_location_provider_excludes_partition_path( PartitionField(source_id=nested_field.field_id, field_id=1001, transform=IdentityTransform(), name=part_col) ) + # write.object-storage.enabled and write.object-storage.partitioned-paths don't need to be specified as they're on by default + assert TableProperties.OBJECT_STORE_ENABLED_DEFAULT + assert TableProperties.WRITE_OBJECT_STORE_PARTITIONED_PATHS_DEFAULT tbl = _create_table( session_catalog=session_catalog, identifier=f"default.arrow_table_v{format_version}_with_null_partitioned_on_col_{part_col}", - # Both write.object-storage.enabled and write.object-storage.partitioned-paths default to True properties={"format-version": str(format_version)}, data=[arrow_table_with_null], partition_spec=partition_spec,