Commit 9610b41
authored
fix: Set Expression serialization to use 'values' (#2782)
Related to #2775
# Rationale for this change
Update the Set Expression serialization to align with the REST spec.
Today, the set expression literals are serialized under items, instead
of values.
For instance:
```json
{
"term": "foo",
"type": "not-in",
"items": [
1,
2,
3
]
}
```
When it should be:
```json
{
"term": "foo",
"type": "not-in",
"values": [
1,
2,
3
]
}
```
**Rest ref**:
https://github.com/apache/iceberg/blob/47d5f5009eafbbb526e6e2c9cbeac3105bf34670/open-api/rest-catalog-open-api.yaml#L2353
**Expression ref**:
https://github.com/apache/iceberg/blob/d19e3ff07653167d902865281601a5da4e2f2def/core/src/main/java/org/apache/iceberg/expressions/ExpressionParser.java#L189-L192
## Are these changes tested?
Yes
## Are there any user-facing changes?
only serialization, and initialization stays the same.1 parent 6806207 commit 9610b41
File tree
2 files changed
+4
-4
lines changed- pyiceberg/expressions
- tests/expressions
2 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
596 | 596 | | |
597 | 597 | | |
598 | 598 | | |
599 | | - | |
| 599 | + | |
600 | 600 | | |
601 | 601 | | |
602 | 602 | | |
603 | | - | |
| 603 | + | |
604 | 604 | | |
605 | 605 | | |
606 | 606 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
915 | 915 | | |
916 | 916 | | |
917 | 917 | | |
918 | | - | |
| 918 | + | |
919 | 919 | | |
920 | 920 | | |
921 | 921 | | |
922 | 922 | | |
923 | | - | |
| 923 | + | |
924 | 924 | | |
925 | 925 | | |
926 | 926 | | |
| |||
0 commit comments