Remove hard-coded release version (#643)

apache · Apr 22, 2024 · 90bcf2c · 90bcf2c
1 parent 05d604a
commit 90bcf2c
Showing 1 changed file with 16 additions and 6 deletions.
diff --git a/mkdocs/docs/verify-release.md b/mkdocs/docs/verify-release.md
@@ -44,12 +44,21 @@ curl https://dist.apache.org/repos/dist/dev/iceberg/KEYS -o KEYS
 gpg --import KEYS
 ```
 
+Set an environment variable to the version to verify and path to use
+
+```sh
+export PYICEBERG_VERSION=<version> # e.g. 0.6.1rc3
+export PYICEBERG_VERIFICATION_DIR=/tmp/pyiceberg/${PYICEBERG_VERSION}
+```
+
 Next, verify the `.asc` file.
 
 ```sh
-svn checkout https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.5.0rc1/ /tmp/pyiceberg/
+svn checkout https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-${PYICEBERG_VERSION}/ ${PYICEBERG_VERIFICATION_DIR}
+
+cd ${PYICEBERG_VERIFICATION_DIR}
 
-for name in $(ls /tmp/pyiceberg/pyiceberg-*.whl /tmp/pyiceberg/pyiceberg-*.tar.gz)
+for name in $(ls pyiceberg-*.whl pyiceberg-*.tar.gz)
 do
     gpg --verify ${name}.asc ${name}
 done
@@ -58,8 +67,8 @@ done
 ## Verifying checksums
 
 ```sh
-cd  /tmp/pyiceberg/
-for name in $(ls /tmp/pyiceberg/pyiceberg-*.whl.sha512 /tmp/pyiceberg/pyiceberg-*.tar.gz.sha512)
+cd ${PYICEBERG_VERIFICATION_DIR}
+for name in $(ls pyiceberg-*.whl.sha512 pyiceberg-*.tar.gz.sha512)
 do
     shasum -a 512 --check ${name}
 done
@@ -68,8 +77,9 @@ done
 ## Verifying License Documentation
 
 ```sh
-tar xzf pyiceberg-0.5.0.tar.gz
-cd pyiceberg-0.5.0
+export PYICEBERG_RELEASE_VERSION=${PYICEBERG_VERSION/rc?/}  # remove rcX qualifier
+tar xzf pyiceberg-${PYICEBERG_RELEASE_VERSION}.tar.gz
+cd pyiceberg-${PYICEBERG_RELEASE_VERSION}
 ```
 
 Run RAT checks to validate license header: