From 626a38760d57014b713b1b21775b7db2f4920f6b Mon Sep 17 00:00:00 2001 From: Mehul Batra Date: Wed, 3 Apr 2024 16:19:51 +0530 Subject: [PATCH] typealias for table version replaced in all files --- pyiceberg/table/__init__.py | 5 +++-- tests/utils/test_manifest.py | 8 ++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/pyiceberg/table/__init__.py b/pyiceberg/table/__init__.py index a9f655ed20..b447129596 100644 --- a/pyiceberg/table/__init__.py +++ b/pyiceberg/table/__init__.py @@ -116,6 +116,7 @@ KeyDefaultDict, Properties, Record, + TableVersion, ) from pyiceberg.types import ( IcebergType, @@ -288,7 +289,7 @@ def _apply(self, updates: Tuple[TableUpdate, ...], requirements: Tuple[TableRequ return self - def upgrade_table_version(self, format_version: Literal[1, 2]) -> Transaction: + def upgrade_table_version(self, format_version: TableVersion) -> Transaction: """Set the table to a certain version. Args: @@ -1018,7 +1019,7 @@ def scan( ) @property - def format_version(self) -> Literal[1, 2]: + def format_version(self) -> TableVersion: return self.metadata.format_version def schema(self) -> Schema: diff --git a/tests/utils/test_manifest.py b/tests/utils/test_manifest.py index 3e789cb854..8bb03cd80e 100644 --- a/tests/utils/test_manifest.py +++ b/tests/utils/test_manifest.py @@ -16,7 +16,7 @@ # under the License. # pylint: disable=redefined-outer-name,arguments-renamed,fixme from tempfile import TemporaryDirectory -from typing import Dict, Literal +from typing import Dict import fastavro import pytest @@ -39,7 +39,7 @@ from pyiceberg.schema import Schema from pyiceberg.table.snapshots import Operation, Snapshot, Summary from pyiceberg.transforms import IdentityTransform -from pyiceberg.typedef import Record +from pyiceberg.typedef import Record, TableVersion from pyiceberg.types import IntegerType, NestedField @@ -308,7 +308,7 @@ def test_read_manifest_v2(generated_manifest_file_file_v2: str) -> None: @pytest.mark.parametrize("format_version", [1, 2]) def test_write_manifest( - generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: Literal[1, 2] + generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: TableVersion ) -> None: io = load_file_io() snapshot = Snapshot( @@ -478,7 +478,7 @@ def test_write_manifest( @pytest.mark.parametrize("format_version", [1, 2]) def test_write_manifest_list( - generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: Literal[1, 2] + generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: TableVersion ) -> None: io = load_file_io()