Skip to content

Commit

Permalink
Verify release quality of life improvements (#626)
Browse files Browse the repository at this point in the history
* fix integration test
* add instruction for verifying release
* use test-coverage
  • Loading branch information
kevinjqliu authored Apr 20, 2024
1 parent 188e2c4 commit 02a5ced
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ test-coverage:
docker compose -f dev/docker-compose-integration.yml up -d
sh ./dev/run-azurite.sh
sh ./dev/run-gcs-server.sh
sleep 10
docker compose -f dev/docker-compose-integration.yml exec -T spark-iceberg ipython ./provision.py
poetry run coverage run --source=pyiceberg/ -m pytest tests/ ${PYTEST_ARGS}
poetry run coverage report -m --fail-under=90
Expand Down
4 changes: 4 additions & 0 deletions mkdocs/docs/how-to-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ https://pypi.org/project/pyiceberg/$VERSION/
And can be installed using: pip3 install pyiceberg==$VERSION
Instructions for verifying a release can be found here:
* https://py.iceberg.apache.org/verify-release/
Please download, verify, and test.
Please vote in the next 72 hours.
Expand Down
10 changes: 6 additions & 4 deletions mkdocs/docs/verify-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,20 @@ And then run the tests:
make test
```

To run the full integration tests:
To run the full test coverage:

```sh
make test-s3
make test-coverage
```

This will include a Minio S3 container being spun up.
This will spin up Docker containers to faciliate running test coverage.

# Cast the vote

Votes are cast by replying to the release candidate announcement email on the dev mailing list with either `+1`, `0`, or `-1`. For example :

> \[ \] +1 Release this as PyIceberg 0.3.0 \[ \] +0 \[ \] -1 Do not release this because…
> \[ \] +1 Release this as PyIceberg 0.3.0 <br>
> \[ \] +0 <br>
> \[ \] -1 Do not release this because… <br>
In addition to your vote, it’s customary to specify if your vote is binding or non-binding. Only members of the Project Management Committee have formally binding votes. If you’re unsure, you can specify that your vote is non-binding. To read more about voting in the Apache framework, checkout the [Voting](https://www.apache.org/foundation/voting.html) information page on the Apache foundation’s website.

0 comments on commit 02a5ced

Please sign in to comment.