Skip to content

Commit 02a5ced

Browse files
authored
Verify release quality of life improvements (#626)
* fix integration test * add instruction for verifying release * use test-coverage
1 parent 188e2c4 commit 02a5ced

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ test-coverage:
6363
docker compose -f dev/docker-compose-integration.yml up -d
6464
sh ./dev/run-azurite.sh
6565
sh ./dev/run-gcs-server.sh
66+
sleep 10
6667
docker compose -f dev/docker-compose-integration.yml exec -T spark-iceberg ipython ./provision.py
6768
poetry run coverage run --source=pyiceberg/ -m pytest tests/ ${PYTEST_ARGS}
6869
poetry run coverage report -m --fail-under=90

mkdocs/docs/how-to-release.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,10 @@ https://pypi.org/project/pyiceberg/$VERSION/
143143
144144
And can be installed using: pip3 install pyiceberg==$VERSION
145145
146+
Instructions for verifying a release can be found here:
147+
148+
* https://py.iceberg.apache.org/verify-release/
149+
146150
Please download, verify, and test.
147151
148152
Please vote in the next 72 hours.

mkdocs/docs/verify-release.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,18 +102,20 @@ And then run the tests:
102102
make test
103103
```
104104

105-
To run the full integration tests:
105+
To run the full test coverage:
106106

107107
```sh
108-
make test-s3
108+
make test-coverage
109109
```
110110

111-
This will include a Minio S3 container being spun up.
111+
This will spin up Docker containers to faciliate running test coverage.
112112

113113
# Cast the vote
114114

115115
Votes are cast by replying to the release candidate announcement email on the dev mailing list with either `+1`, `0`, or `-1`. For example :
116116

117-
> \[ \] +1 Release this as PyIceberg 0.3.0 \[ \] +0 \[ \] -1 Do not release this because…
117+
> \[ \] +1 Release this as PyIceberg 0.3.0 <br>
118+
> \[ \] +0 <br>
119+
> \[ \] -1 Do not release this because… <br>
118120
119121
In addition to your vote, it’s customary to specify if your vote is binding or non-binding. Only members of the Project Management Committee have formally binding votes. If you’re unsure, you can specify that your vote is non-binding. To read more about voting in the Apache framework, checkout the [Voting](https://www.apache.org/foundation/voting.html) information page on the Apache foundation’s website.

0 commit comments

Comments
 (0)