feat(evaluator): Add strict metrics evaluator #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
requested changes
Aug 5, 2025
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Looks good other than the one issue
Comment on lines
+1459
to
+1461
| if cmp(upperBound, lit) == -1 { | ||
| return rowsMustMatch | ||
| } |
Member
There was a problem hiding this comment.
if there was no lower bound in the stats, this will panic because cmp will be nil. It'll never get set if there's no lower bound. we should avoid that 😄
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this! I think inclusiveMetrics might have the same issue as well https://github.com/apache/iceberg-go/blob/main/table/evaluators.go#L1000
Member
There was a problem hiding this comment.
Looks like you're right, can you add the fix there too?
Contributor
Author
There was a problem hiding this comment.
Yes, actually already fixed it in my new commit
zeroshade
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
trueor should read the data file will when the expression exactly matched by the manifest statistics.Testing
evaluators_test.go