From 327c1e47e2a4caaff4f3e769fc9bf85c804c993e Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 7 Mar 2025 17:35:38 -0500 Subject: [PATCH 1/2] Minor: split datafusion-cli testing into its own CI job --- .github/workflows/rust.yml | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 2f7ab418ca77..f80715c7b7f3 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -166,7 +166,7 @@ jobs: - name: Check datafusion-functions (string_expressions) run: cargo check --profile ci --all-targets --no-default-features --features=string_expressions -p datafusion-functions - # Run tests + # Library and integration tests linux-test: name: cargo test (amd64) needs: linux-build-lib @@ -180,6 +180,36 @@ jobs: run: rustup toolchain install stable - name: Install Protobuf Compiler run: sudo apt-get install -y protobuf-compiler + - name: Run tests (excluding doctests and datafusion-cli) + env: + RUST_BACKTRACE: 1 + run: | + cargo test \ + --profile ci \ + --exclude datafusion-examples \ + --exclude ffi_example_table_provider \ + --exclude datafusion-benchmarks \ + --exclude datafusion-cli \ + --workspace \ + --lib \ + --tests \ + --bins \ + --features avro,json,backtrace,integration-tests + - name: Verify Working Directory Clean + run: git diff --exit-code + + # datafusion-cli tests + linux-test-datafusion-cli: + name: cargo test datafusion-cli (amd64) + needs: linux-build-lib + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + with: + submodules: true + fetch-depth: 1 + - name: Setup Rust toolchain + run: rustup toolchain install stable - name: Setup Minio - S3-compatible storage run: | docker run -d --name minio-container \ @@ -200,13 +230,14 @@ jobs: AWS_SECRET_ACCESS_KEY: TEST-DataFusionPassword TEST_STORAGE_INTEGRATION: 1 AWS_ALLOW_HTTP: true - run: cargo test --profile ci --exclude datafusion-examples --exclude ffi_example_table_provider --exclude datafusion-benchmarks --workspace --lib --tests --bins --features avro,json,backtrace,integration-tests + run: cargo test --profile ci -p datafusion-cli --lib --tests --bins - name: Verify Working Directory Clean run: git diff --exit-code - name: Minio Output if: ${{ !cancelled() }} run: docker logs minio-container + linux-test-example: name: cargo examples (amd64) needs: linux-build-lib From e8352a5cdc2496e623609897795dda530810dd52 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Tue, 11 Mar 2025 11:12:01 -0400 Subject: [PATCH 2/2] fix --- .github/workflows/rust.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index f80715c7b7f3..e4904d226637 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -194,7 +194,7 @@ jobs: --lib \ --tests \ --bins \ - --features avro,json,backtrace,integration-tests + --features serde,avro,json,backtrace,integration-tests - name: Verify Working Directory Clean run: git diff --exit-code