Skip to content

Apply minor refactorings to functions-array crate #9787

Closed
@erenavsarogullari

Description

@erenavsarogullari

Is your feature request related to a problem or challenge?

functions-array create is introduced in terms of Epic: #9285. This issue aims to apply following minor refactorings to functions-array create:
1- Being added make_scalar_function support to missed invoke functions,
2- Aligning rust-doc across array functions,
3- Removing redundant imports,
4- Fixing typo problems,
5- Rename core.rs -> make_array.rs.

Describe the solution you'd like

Apply minor refactorings (listed above section) to functions-array create

Describe alternatives you've considered

No response

Additional context

No response

Questions:

1- Currently, all array functions are under src directory of functions-array crate. Does it make sense to package them by separating from infra source files as follows?

/functions-array
	/src
		/functions
			array_has.rs
			...
			string.rs
		lib.rs
		macros.rs
		rewrite.rs
		utils.rs

2- array_empty function is named as empty. Should we rename it as array_empty to be consistent with other array functions naming convention?

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions