Skip to content

Conversation

@Weijun-H
Copy link
Member

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Oct 12, 2025
@Weijun-H Weijun-H force-pushed the 18002-better-merge-content branch from ac3763c to b1540fe Compare October 12, 2025 13:13
@Weijun-H Weijun-H changed the title feat: update .asf.yaml configuration settings ci: Use PR description for merge commit body in squash merges Oct 12, 2025
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a way to test this 🤔

@Weijun-H
Copy link
Member Author

Do we have a way to test this 🤔

I don't know the way to test it. But it is fine to ship it because arrow-rs did it in the same way.

@Weijun-H Weijun-H force-pushed the 18002-better-merge-content branch from b1540fe to 6be20df Compare October 15, 2025 12:36
@comphead
Copy link
Contributor

Thanks @Weijun-H if you can attach a screenshot would be nice

@Weijun-H Weijun-H force-pushed the 18002-better-merge-content branch from 6be20df to 48d03ed Compare October 15, 2025 19:06
@Weijun-H
Copy link
Member Author

Thanks @Weijun-H if you can attach a screenshot would be nice

I can't test this on my fork due to the asf setting, but it should be safe to ship.

@Weijun-H Weijun-H added this pull request to the merge queue Oct 16, 2025
Merged via the queue into apache:main with commit c8e0f1c Oct 16, 2025
28 checks passed
@Weijun-H
Copy link
Member Author

Update:: It did work 🚀
图片

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge when ready should use pull request description for merge commit body (or make it configurable)

3 participants