Enable placeholders with extension types #17986

paleolimbot · 2025-10-08T22:13:56Z

Which issue does this PR close?

Closes Logical plan placeholders can't contain metadata #17862

Rationale for this change

Most logical plan expressions now propagate metadata; however, parameters with extension types or other field metadata cannot participate in placeholder/parameter binding.

What changes are included in this PR?

The DataType in the Placeholder struct was replaced with a FieldRef along with anything that stored the "DataType" of a parameter.

Strictly speaking one could bind parameters with an extension type by copy/pasting the placeholder replacer, which I figured out towards the end of this change. I still think this change makes sense and opens up the door for things like handling UUID in SQL with full parameter binding support.

Are these changes tested?

Yes

Are there any user-facing changes?

Yes, one new function was added to extract the placeholder fields from a plan.

This is a breaking change for code that specifically interacts with the pub fields of the modified structs (ParamValues, Placeholder, and Prepare are the main ones).

paleolimbot

@timsaucer @alamb I'm happy to add tests for all these components but wanted to make sure this is vaugely headed in the right direction before I do so!

paleolimbot · 2025-10-10T02:38:22Z

datafusion/expr/src/expr.rs

-    pub data_type: Option<DataType>,
+    pub field: Option<FieldRef>,


This is the main change. We can change this to a less severely breaking option (e.g., just add metadata: FieldMetadata to the struct)...I started with the most breaking version to identify its use in as many places as possible.

datafusion/core/src/execution/session_state.rs

datafusion/sql/src/planner.rs

paleolimbot · 2025-10-10T02:49:01Z

datafusion/sql/src/planner.rs

-    pub(crate) fn convert_data_type(&self, sql_type: &SQLDataType) -> Result<DataType> {
+    pub(crate) fn convert_data_type(&self, sql_type: &SQLDataType) -> Result<FieldRef> {


I think this change would also enable supporting UUIDs and other SQL types that map to extension types

datafusion/sql/src/statement.rs

paleolimbot · 2025-10-10T02:51:45Z

datafusion/sql/src/expr/mod.rs

+        Ok(Expr::Cast(Cast::new(
+            Box::new(expr),
+            dt.data_type().clone(),
+        )))


Another place where metadata is dropped that I didn't update (casts)

I made #18060 for this one

datafusion/expr/src/logical_plan/plan.rs

datafusion/sql/tests/cases/params.rs

paleolimbot · 2025-10-10T02:57:34Z

datafusion/common/src/metadata.rs

+#[derive(Clone, PartialEq, Eq, PartialOrd, Hash, Debug)]
+pub struct FieldMetadata {


I just moved this from the expr crate so I could us it in ParamValues

alamb

Thank you @paleolimbot -- I think this is definitely the right direction. I had some small API suggestions, but overall looks good

The largest open question in my mind is what you have highlighted for customizing behavior for different extension types (e.g. comparing two fields for "equality" and printing them, and casting them, etc.)

@findepi brought up the same thing many months ago when discussing adding new types in

#12644

One idea is to create a TypeRegistry similar to a FunctionRegistry and some sort of ExtensionType trait that encapsulates these behaviors.

The challenge would then be to thread the registry to all places that need it. Though that is likely largely an API design / plumbing exercise

If you think that is an idea worth exploring

alamb · 2025-10-10T10:53:39Z

datafusion/common/src/param_value.rs

 impl ParamValues {
    /// Verify parameter list length and type
-    pub fn verify(&self, expect: &[DataType]) -> Result<()> {
+    pub fn verify(&self, expect: &[FieldRef]) -> Result<()> {


one thing that would be nice to help people upgrade could be to add a new function and deprecate this one -- perhaps something like suggested in https://datafusion.apache.org/contributor-guide/api-health.html#api-health-policy

#[deprecated] pub fn verify(&self, expect: &[DataType]) -> Result<()> { // make dummy Fields let expect = ...; self.verify_fields(&expect) } // new function that has the new signature pub fn verify_fields(&self, expect: &[FieldRef]) -> Result<()> { ... }

alamb · 2025-10-10T10:55:00Z

datafusion/common/src/param_value.rs

                    }
+
+                    if let Some(expected_metadata) = maybe_metadata {
+                        // Probably too strict of a comparison (this is an example of where


Yeah, I agree straight up comparing strings is probably not ideal

If we wanted to introduce type equality, I thing the bigger question is how to thread it through (you would have to have some way to register your types / methods to check equality and ensure that somehow ended up here 🤔 )

datafusion/sql/tests/cases/params.rs

tobixdev · 2025-10-13T20:42:18Z

One idea is to create a TypeRegistry similar to a FunctionRegistry and some sort of ExtensionType trait that encapsulates these behaviors.

I've stumbled across this PR and remembered that I implemented such a thing in #15106 for defining custom sort orders for certain types. I now have a bit more time on my hand and I'll try to revive that effort as we would be still interested in that.

paleolimbot · 2025-10-14T16:55:47Z

Thank you for the review! I will clean this up today/tomorrow and ensure we can test all the spots.

I now have a bit more time on my hand and I'll try to revive that effort as we would be still interested in that.

I'd love that! Perhaps the first step from the non-sorting angle might be to just consolidate all the places we print, cast, or test equality (which are currently scattered around the code base).

A vague thought based mostly on this PR, SedonaDB's SedonaType, and the one linked (likely needs much refinement):

pub fn resolve_df_data_type(session: Option<SessionSomething>, storage_type: &DataType, metadata: impl MetadataViewOfSomeSort ) -> Box<dyn DFDataType> {
  // sanity check to avoid hitting the lock on any registry whatsoever when not needed)

  // If the session is specified, use a session registry

  // otherwise, use a static or compile-time populated registry until such a time as the session
  // is made available everywhere and/or DataType::Extension is a thing
}

pub trait DFDataType: Clone {
  fn storage_type(&self) -> DataType;
  // e.g., the sanity check on the return field of a UDxF
  fn type_identical_to(&self, &dyn DFDataType) -> Result<bool>;
  // for when this has to be a storage field (it might already be one)
  fn storage_field(&self, name: Option<&str>, nullability: Option<bool>) -> FieldRef;
  fn add_to_existing_storage_field(&self
  // for when this has to be just metadata (e.g., the Expr::Literal)
  fn storage_field_metadata(&self) -> Option<FieldMetadata>;
  // to avoid dumping a Field debug string in user-facing errors
  fn display_type(&self) -> String;
  // for any hope of ever being able to deal with shredded/unshredded variants in UNION ALL
  // slash listing tables. This is useful for some geoarrow types too (wkb/wkb_view -> wkb)
  fn common_castable_type(&self, &dyn DFDataType) -> Result<Box<dyn DFDataType>> { /* self if types are identical or error */ }
  // usually printing the storage is OK but no ideal (e.g., variants should be jsonish)
  fn format_proxy(&self, storage: ArrayRef) -> Result<ArrayRef> { Ok(storage) }
  // Or something more advanced like the dynamic comparator in the linked PR
  fn sort_proxy(&self, storage: ArrayRef) -> Result<ArrayRef> { Ok(storage) }
  // It's a shame to bleed execution in here but casting shows up a lot
  fn cast_storage(&self, storage: ArrayRef, to: Box<dyn DFDataType>);
}

// All the structures that are currently communicating that type information

impl DFDataType for FieldMetadata {
  // implement strict equality based on all metadata (or just extension name/extension metadata?)
  // printing based on metadata
  // everything else based on datatype
  // ...basically everything datafusion does right now
}

impl DFDataType for FieldRef {
  // defer to fieldmetadata
}

impl DFDataType for DataType {
 // defer to DataTypes
}

tobixdev · 2025-10-15T06:50:22Z

Btw, if you want another set of eyes you can ping me once its ready for another review.

paleolimbot · 2025-10-15T19:12:19Z

Thank you...I'd love that! I just need to finish up a few tests...I didn't quite get there today but I'm confident I can get this ready for eyes tomorrow.

paleolimbot · 2025-10-16T22:52:58Z

datafusion/common/src/metadata.rs

+/// A [`ScalarValue`] with optional [`FieldMetadata`]
+#[derive(Debug, Clone)]
+pub struct Literal {
+    pub value: ScalarValue,
+    pub metadata: Option<FieldMetadata>,
+}
+
+impl Literal {
+    /// Create a new Literal from a scalar value with optional [`FieldMetadata`]
+    pub fn new(value: ScalarValue, metadata: Option<FieldMetadata>) -> Self {
+        Self { value, metadata }
+    }


I am not sure Literal is the best name here (we already have the trait datafusion_expr::Literal and datafusion_physical_expr::Literal), but ScalarValueAndMetadata seemed verbose and using (ScalarValue, Option<FieldMetadata>) has been used in enough places that I think having its own struct makes sense.

Other places where we pair a ScalarValue with metadata are Expr::Literal, and ConstSimplifyResult::Simplified.

I don't have strong opinions here and am happy to have this be whatever.

paleolimbot · 2025-10-16T22:55:57Z

datafusion/common/src/metadata.rs

+pub fn check_metadata_with_storage_equal(
+    actual: (
+        &DataType,
+        Option<&std::collections::HashMap<String, String>>,
+    ),
+    expected: (
+        &DataType,
+        Option<&std::collections::HashMap<String, String>>,
+    ),
+    what: &str,
+    context: &str,
+) -> Result<(), DataFusionError> {


This is kind of ugly but there are two places in this PR that do this check (type equality). I figured at least collecting the checks in one place would make it easier to do something smarter later if it comes up.

paleolimbot · 2025-10-16T22:57:27Z

datafusion/common/src/metadata.rs

+pub fn format_type_and_metadata(
+    data_type: &DataType,
+    metadata: Option<&std::collections::HashMap<String, String>>,
+) -> String {


This is to keep the LogicalType::Statement(Prepared {..}) output in the plan text from dumping the debug output from Field so that it is mostly unchanged (unless there is, in fact, metadata). Also helps with the error message above.

paleolimbot · 2025-10-16T23:00:09Z

datafusion/expr/src/expr_schema.rs

+                    Expr::Placeholder(Placeholder { field, .. }) => match &field {
+                        // TODO: This seems to be pulling metadata/types from the schema
+                        // based on the Alias destination. name? Is this correct?
+                        None => schema
+                            .field_from_column(&Column::from_name(name))
+                            .map(|f| f.clone().with_name(&schema_name)),


I don't understand this first branch and why it would pull metadata from a schema based on the destination name?

paleolimbot · 2025-10-17T14:18:29Z

This is ready for 👀! @tobixdev

The CI failure is

1. query is expected to fail, but actually succeed:
[SQL] SELECT ALL ( + 73 ) + - + 92 * - 97 + COALESCE ( + ( + NULLIF ( + 75, - MIN ( ALL + + 53 ) ) ), + ( - CASE - - 73 WHEN COALESCE ( - + 51, - 26 ) / + 0 THEN COUNT ( * ) * 14 END ), + COUNT ( * ) / + 3, + COUNT ( ALL 73 ) ) + - 86 * ( 8 ) * + 37 AS col1

I'm happy to take a look if this keeps showing up.

alamb · 2025-10-17T16:17:53Z

I'm happy to take a look if this keeps showing up.

I believe that is due to this issue (which was fixed yesterday)

extended tests failures on main #18084

It should be fixed with a merge up from main

github-actions bot added sql SQL Planner logical-expr Logical plan and expressions proto Related to proto crate physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate common Related to common crate labels Oct 8, 2025

paleolimbot force-pushed the params-with-metadata branch from 97a8408 to 04cebe1 Compare October 10, 2025 01:37

github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Oct 10, 2025

paleolimbot commented Oct 10, 2025

View reviewed changes

alamb reviewed Oct 10, 2025

View reviewed changes

paleolimbot mentioned this pull request Oct 14, 2025

LogicalPlan Casts can't express a cast to an extension type #18060

Open

github-actions bot removed the sqllogictest SQL Logic Tests (.slt) label Oct 14, 2025

paleolimbot mentioned this pull request Oct 16, 2025

SubqueryAlias, Values, and/or EmptyRelation have incorrect schemas after replacing Placeholder values #18102

Open

paleolimbot force-pushed the params-with-metadata branch from 9b6c182 to 27e8e42 Compare October 16, 2025 18:50

paleolimbot added 11 commits October 16, 2025 17:38

start

6269073

builds!

585bba9

backward compatible proto

16ac02d

move FieldMetadata

a702499

maybe working from proto

2c98b28

oof

cbf75aa

maybe fix build

9982d32

fix doc

0091bbb

fix the name of the list

4f01800

undo trailing whitespace change

9b3a45a

maybe fix failing tests

901a011

paleolimbot added 17 commits October 16, 2025 17:38

possibly reusable type equality

21af946

literal class

b7404c0

doc

94cb418

one more pass on documenting things

b982d4c

use the equality checker in one more place

4f4820b

update data_types variables that were actually fields

63ae6fb

revert tests

a085cf1

fix slt

5475937

add a test that fails

05431a2

fix test

45f15f4

add tests for expression schema for typed parameters

4386a85

more tests

8b5622f

add placeholder inference test

df5aba8

add nullability to test

08d0e7a

tests for proto

2b4b8e7

make sure I don't forget these

57437b9

fix typo

70f3663

paleolimbot force-pushed the params-with-metadata branch from 479fe56 to 70f3663 Compare October 16, 2025 22:38

paleolimbot added 2 commits October 16, 2025 17:58

remove comment

58807fd

fix

4bfc5cd

paleolimbot marked this pull request as ready for review October 16, 2025 23:02

paleolimbot added 3 commits October 16, 2025 21:18

fmt

81c3baf

fix error string comparison

860e013

add update/insert test

b6c71b3

paleolimbot commented Oct 17, 2025

View reviewed changes

Merge branch 'main' into params-with-metadata

cfabfd0

paleolimbot mentioned this pull request Oct 17, 2025

Allow logical expressions to express a cast to an extension type #18136

Draft

		pub data_type: Option<DataType>,
		pub field: Option<FieldRef>,

		pub(crate) fn convert_data_type(&self, sql_type: &SQLDataType) -> Result<DataType> {
		pub(crate) fn convert_data_type(&self, sql_type: &SQLDataType) -> Result<FieldRef> {

		#[derive(Clone, PartialEq, Eq, PartialOrd, Hash, Debug)]
		pub struct FieldMetadata {

Enable placeholders with extension types #17986

Are you sure you want to change the base?

Enable placeholders with extension types #17986

Uh oh!

Conversation

paleolimbot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

paleolimbot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alamb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tobixdev commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paleolimbot commented Oct 14, 2025

Uh oh!

tobixdev commented Oct 15, 2025

Uh oh!

paleolimbot commented Oct 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paleolimbot commented Oct 17, 2025

Uh oh!

alamb commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paleolimbot commented Oct 8, 2025 •

edited

Loading

tobixdev commented Oct 13, 2025 •

edited

Loading