Split up monster test_window_partial_constant_and_set_monotonicity into smaller functions

[alamb]

Which issue does this PR close?

• Another try at Refactor: Split test_window_partial_constant_and_set_monotonicity from enforce_sorting #17903
• Part of [WIP] Upgrade to arrow/parquet 57.0.0 #17888

Rationale for this change

I am working on the arrow 57 upgrade and I found I had to update the output of
many tests. I broke some of the changes out into their own PR for easier review

This one in particular breaks the 1200+ line test test_window_partial_constant_and_set_monotonicity, including the 63 test cases in into individual tests so they are easier to update.

Without this change, updating the 63 tests requires running the following commands in a loop (63 times):

cargo test --profile=ci --test core_integration -- enforce_sorting # fails on the first diff
cargo insta review # (and then hit a to accept the changes for the first diff)

What changes are included in this PR?

1. Move the code to a new file
2. Move testing code into functions rather than a macro
3. Rewrite all test cases (used copilot and carefully validated the plans did not change)

Are these changes tested?

Are there any user-facing changes?

[alamb]

I rewrote the harness to be a proper structure rather than macro, and then carefully ported each test
with the help of copilot magic auto complete.

I did not let copilot stick in the expected plan output -- instead I used the pre-existing plan output

[blaginin]

Verified the above:

• manually checked some tests
• wrote a code to compare before and after: https://gist.github.com/blaginin/903ccb038360f89711a4ab1711a729c2
• manually changed some before/auto to confirm it's working

[alamb]

@blaginin I don't know if you are interested/willing to review another massive test refactor PR but this would really help me in my quest to update to arrow 57

[blaginin]

of course! will check now

[blaginin]

Without this change, updating the 63 tests requires running the following commands in a loop (63 times):

cargo test --profile=ci --test core_integration -- enforce_sorting # fails on the first diff

I totally agree that this test needs to be changed - but just wanted let you know - if you run cargo insta test instead of cargo test - it'll update everything at once 🙂

[alamb]

I totally agree that this test needs to be changed - but just wanted let you know - if you run cargo insta test instead of cargo test - it'll update everything at once 🙂

TIL

[alamb]

BTW I think CI will fail due to unrelated reasons:

• CI is failing on main / current_date() = cast(now() as date); #18062

[blaginin]

much cleaner and easier to debug! 🚀

[blaginin]

have two more small prs to migrate core, hoping to do them today evening or tomorrow and that should be it

[blaginin]

if there's anything else to migrate feel free to throw for me too!

[alamb]

have two more small prs to migrate core, hoping to do them today evening or tomorrow and that should be it

Awesome -- thanks @blaginin -- I will stand by for reviews